Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#3558 closed defect (fixed)

Read shows "%" zoom submenu label as black on dark background

Reported by: greenfeld Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Unspecified Keywords: 12.1.0, olpc-testing-pending
Cc: Distribution/OS: OLPC
Bug Status: Assigned

Description (last modified by greenfeld)

Read-99 shows its "%" zoom submenu/custom control label with black text on a dark background on OLPC 12.1.0 os8.

There are similar tickets on this subject such as #3479.

Change History (10)

comment:1 Changed 9 years ago by greenfeld

  • Description modified (diff)

comment:2 Changed 9 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Keywords 12.1.0 added
  • Milestone changed from Unspecified by Release Team to 0.96
  • Version changed from Unspecified to Git as of bugdate

Good catch, would be great to do something about this.

comment:3 Changed 9 years ago by greenfeld

Given this is showing up in more than one activity, is this a sign there is a problem with the core Sugar libraries and/or theme?

Or has no one thought of making sure all Sugar activities could tolerate theme changes before?

comment:4 Changed 9 years ago by walter

I submitted a patch in regard to #3479 that addresses this issue (and a similar one for alerts) in Abacus. But it is a change in the default behavior of the Sugar label style. We should really fix it in the toolkit.

comment:5 Changed 9 years ago by erikos

  • Keywords patch added
diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em
index dce2a58..7ef8448 100644
--- a/gtk3/theme/gtk-widgets.css.em
+++ b/gtk3/theme/gtk-widgets.css.em
@@ -505,6 +505,10 @@ SugarPaletteWindowWidget GtkToolButton .button {
     padding: $(default_padding)px;
 }
 
+.toolbar GtkLabel {
+    color: @white;
+}
+
 .toolbar GtkToolButton .button:prelight,
 SugarPaletteWindowWidget GtkToolButton .button:prelight {
     background-color: @black;

The patch does fix the Read case and Abacus as well.

comment:6 Changed 9 years ago by godiard

  • Component changed from Read to sugar-artwork
  • Owner changed from godiard to benzea

Thanks erikos

Tested. Works ok and can remove more hardcoded white color in Read activity.

Change component to sugar-artwork.

comment:7 Changed 9 years ago by erikos

  • Keywords olpc-testing-pending added; patch removed
  • Owner changed from benzea to erikos
  • Status changed from new to assigned

Great, pushed as: bf8a5d25ddf9d12fc7e2aa4c50ff014ae6dbac7d

comment:8 Changed 9 years ago by erikos

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:9 Changed 8 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:10 Changed 8 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.