Opened 11 years ago

Last modified 9 years ago

#3526 new defect

Correct theming for elements in Browse

Reported by: erikos Owned by: erikos
Priority: Normal Milestone:
Component: Browse Version: Git as of bugdate
Severity: Major Keywords: 12.1.0
Cc: manuq Distribution/OS: OLPC
Bug Status: New

Description

see screenshot

Attachments (4)

Bildschirmfoto von _bugs_.png (79.8 KB) - added by erikos 11 years ago.
screenshot from bug tracker
browse-theme.JPG (121.2 KB) - added by erikos 11 years ago.
Browse theme with gtk2
browse-theme-gtk3.JPG (122.9 KB) - added by erikos 11 years ago.
browse theme with gtk3
patch (1.4 KB) - added by garnacho 11 years ago.
patch for sugar WebKit, unfortunately not suitable for upstream

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by erikos

screenshot from bug tracker

comment:1 Changed 11 years ago by erikos

  • Bug Status changed from Unconfirmed to New
  • Cc manuq added
  • Component changed from untriaged to Browse
  • Distribution/OS changed from Unspecified to OLPC
  • Keywords 12.1.0 added
  • Milestone changed from Unspecified by Release Team to 0.96
  • Owner set to erikos
  • Severity changed from Unspecified to Major
  • Version changed from Unspecified to Git as of bugdate

Changed 11 years ago by erikos

Browse theme with gtk2

Changed 11 years ago by erikos

browse theme with gtk3

comment:2 Changed 11 years ago by garnacho

I'm attaching a tentative patch which resets form elements within a web view to the default GTK+ theme, as WebKit lacks the concept of a fallback theme. This needs to be done within WebKit (and not Browse/Ephy) because the GtkWidgetPaths created to theme the form elements are disconnected from the real widget hierarchy.

Changed 11 years ago by garnacho

patch for sugar WebKit, unfortunately not suitable for upstream

comment:3 Changed 11 years ago by garycmartin

What would it take to make the Sugar theme work better in WebKit Browse? As that would seem like the idea design choice providing a unified and consistent Sugar UI experience.

comment:4 Changed 11 years ago by garnacho

That's also a possibility, WebKit just needs theming for the limited set of elements that appear in forms, and AFAICS the most glaring problem is with radio/check buttons, it should be possible to install dedicated files to theme webkit that @include gtk-widget-${dpi}.css and forces downsizing of those elements.

comment:5 Changed 10 years ago by humitos

  • Priority changed from Unspecified by Maintainer to Normal

comment:6 Changed 9 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.