#3525 closed defect (fixed)
Add DescriptionItem to activities with custom toolbars
Reported by: | godiard | Owned by: | garycmartin |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | |
Component: | ActivityTeam | Version: | Unspecified |
Severity: | Unspecified | Keywords: | |
Cc: | Distribution/OS: | Unspecified | |
Bug Status: | New |
Description
In sugar 0.96 we implemented the "Write to Journal Anytime" feature [1], to allow the user to modify the journal description. The change is done in sugar-tolkit code, and the activities using the standard toolbar have it, but activities with custom toolbars need add the item in the activity code.
The activities needing patches are: Distance, Hello world, Chat, Stopwatch, TamtamMini and Words
[1] http://wiki.sugarlabs.org/go/Features/Write_to_journal_anytime
Change History (9)
comment:1 follow-up: ↓ 2 Changed 11 years ago by walter
comment:2 in reply to: ↑ 1 Changed 11 years ago by garycmartin
Replying to walter:
For at least some of these activities, it is not clear to me that they need custom toolbars. I presume the goal was to save some canvas space by not using a secondary toolbar, but Distance uses secondary toolbars for other things; Hello World certainly should use standard toolbars; Stopwatch doesn't really have a serious space constraint; nor does Words or Chat. TamTamMini is about the only one on the list that might merit custom toolbars.
+1 Agreed, even TamTamMini unfortunately now requires scrolling the main view (not very friendly for very young children), so even there, a secondary toolbar that eats a little more screen space if it is opened is no major step back. I'd much rather we standardised and dropped the 'basic' toolbar layout (fwiw there are lot's of little implementation/behaviour bugs in the above activity 'basic' toolbars anyway that would need fixing if we keep them).
comment:3 Changed 11 years ago by godiard
Probably you are right. Please fill tickets for the activities.
May be we should be more explicit in the documentation about this?
comment:4 Changed 11 years ago by sascha_silbe
- Component changed from untriaged to ActivityTeam
- Owner set to garycmartin
comment:5 follow-up: ↓ 6 Changed 11 years ago by godiard
Last pending activities are StopWatch and Speak. Patches sent to maintainers.
Thread http://lists.sugarlabs.org/archive/sugar-devel/2012-May/037732.html
comment:6 in reply to: ↑ 5 Changed 11 years ago by alsroot
Replying to godiard:
Last pending activities are StopWatch and Speak. Patches sent to maintainers.
Thread http://lists.sugarlabs.org/archive/sugar-devel/2012-May/037732.html
Speak was updated in v40.
comment:7 Changed 11 years ago by RafaelOrtiz
Stopwatch has this feature on V16.
comment:8 Changed 11 years ago by godiard
- Resolution set to fixed
- Status changed from new to closed
Thanks Rafael.
Closing ticket.
For at least some of these activities, it is not clear to me that they need custom toolbars. I presume the goal was to save some canvas space by not using a secondary toolbar, but Distance uses secondary toolbars for other things; Hello World certainly should use standard toolbars; Stopwatch doesn't really have a serious space constraint; nor does Words or Chat. TamTamMini is about the only one on the list that might merit custom toolbars.