Paint OS8 - invert colors tears image

[tonyforster]

OS8 XO-1.75

select an area and apply the invert colors tool, the image becomes skewed, looks like its got the number of pixels per row wrong

[humitos]

It works for me in jhbuild with git version of Paint.

[humitos]

I could reproduce this bug in XO 1.5 12.1.0 with git version of Paint

[godiard]

Can be a bug related in any way to different selections?

There are no differences in the fill code between the v42 and git HEAD

[humitos]

Replying to godiard:

Can be a bug related in any way to different selections?

I don't think. I tested it several times in XO and sugar-jhbuild. In XO I always had the problem.

I think it's related with some version of a library. We are using:

• numpy / string
• gtk.gdk.Pixbuf
• gtk.gdk.pixbuf_new_from_array / gtk.gdk.pixbuf_new_from_data
• gtk.gdk.COLORSPACE_RGB
• gtk.gdk.RGB_DITHER_NORMAL

I would compare versions of those libs.

[humitos]

Tested again with the correct version of the Git Repository. Same results.

[humitos]

numpy:

• jhbuild: 1.5.1
• XO 1.5 12.1.0: 1.6.1

After upgrading the "numpy" version in my jhbuild to "1.6.1" I can reproduce the error on my jhbuild instance.

So, it's a library version problem. numpy 1.6.1 has a bug.

Here is the function that uses numpy:

• ​http://git.sugarlabs.org/paint/mainline/blobs/master/Area.py#line1033

What should we do in this case?

[humitos]

• cat ~/.sugar/default/logs/org.laptop.Oficina-6.log

  /home/humitos/Activities/Paint.activity/Desenho.py:660: GtkWarning: _gdk_pixmap_new: assertion `(width != 0) && (height != 0)' failed
    widget.pixmap_sel = gtk.gdk.Pixmap(widget.window, dx, dy, -1)
  Traceback (most recent call last):
    File "/home/humitos/Activities/Paint.activity/Area.py", line 591, in mouseup
      self.d.selection(widget, coords, False)
    File "/home/humitos/Activities/Paint.activity/Desenho.py", line 660, in selection
      widget.pixmap_sel = gtk.gdk.Pixmap(widget.window, dx, dy, -1)
  RuntimeError: could not create GdkPixmap object
  

[humitos]

Replying to humitos:

• cat ~/.sugar/default/logs/org.laptop.Oficina-6.log

  ----
  RuntimeError: could not create GdkPixmap object
  

This error happens when you click with the "selection" tool and release the button without moving the mouse. But it isn't related with the invert colors issue

[humitos]

There are two ways to do the inversion: using string and using numpy. The "string" version works properly. Maybe we can just comment the numpy version if we are going to release a new version of sugar in the following days.

[godiard]

Thanks humitos, pushed as cc044ab4fa08b8e0e143f251ef634322e4f81b40

Available in Paint 43