Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#3504 closed defect (fixed)

New description feature not translated

Reported by: erikos Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Major Keywords: 12.1.0
Cc: cjl Distribution/OS: OLPC
Bug Status: Resolved

Description

The new desciprion feature does not seem to have been translated (yet). The button does say 'Description' in German and Spanish.

src/sugar/activity/widgets.py:246: description_button.set_tooltip(_('Description'))

This is a pity because we do have nearly the same string translated in the sugar repository:

sugar/src/jarabe/journal/expandedentry.py:323: text = hippo.CanvasText(text=_('Description:')

Change History (10)

comment:1 Changed 9 years ago by erikos

  • Cc cjl added

comment:2 Changed 9 years ago by erikos

According to Gonzalo the string is translated in toolkit-gtk3 in PSanihs, but not pushed to git.

comment:3 Changed 9 years ago by godiard

I have tried to push the changes from the pootle interface, but show git errors doing it.

comment:4 follow-up: Changed 9 years ago by cjl

Working on the Pootle error now.

comment:5 in reply to: ↑ 4 Changed 9 years ago by erikos

Replying to cjl:

Working on the Pootle error now.

Thanks Chris! We did land the same Feature in the sugar-toolkit. Maybe, the existing translations can be magically transferred (but is enough to do for 0.96.1). /me wants to get the 0.96.0 out first

comment:6 Changed 9 years ago by cjl

So all of the namingalert strings are going away?

Name this entry
Untitled
Tags:

and sugar-toolkit.po goes from 78 to 73 words.

You will pick up a fuzzy match against the former

../src/sugar/activity/namingalert.py:290
Description:

Deleting the puncutation at the end makes it a perfect match.

I'll do the refresh.

comment:7 Changed 9 years ago by cjl

  • Resolution set to fixed
  • Status changed from new to closed

We are talking about a string added hours ago by this commit:

http://git.sugarlabs.org/sugar-toolkit/mainline/commit/aaea3591e27adfafa6a5b47a63a309b15bbbff20

We refresh POT files nightly at midnight and if the string is identical to an existing string in the PO file, then the translation of that msgid will be retained and shared with the new call on it and the PO file will change by adding the additional location comment on where it appears. We will also get fuzzy matches from the Template update process.

Adding a "new" string (or another copy of an existing string in a new location) and expecting several hour turn-around on a process that is automated to run on it's own at midnight is not an entirely reasonable expectation. I am reluctant to mess with manually kicking off some of the cron job elements as I do not work with their syntax and argument requirements on a regular basis. That is what the cron job is for.

The cron job having done it's work, I've refreshed the languages from the modified template and even submitted and committed a number of them that were easy to complete.

This was not so much a bug, as it was a very last minute string-freeze break, let's try not to do that too much.

Closing as fixed.

comment:8 Changed 9 years ago by erikos

  • Bug Status changed from New to Resolved

Thanks for having a look at this Chris!

So the "description" string sugar-toolkit-gtk3 and sugar-toolkit is fixed, just tested both. In sugar-toolkit-gtk3 the string was present for a long time, but the translation for example in spanish had not been pushed - that was what this ticket was about.

In sugar-toolkit we did port that feature pack recently, and yes - it is true that this added that string. I should have asked officially before pushing but I thought that the string was already translated - seen after me pusing pushy that there was this ':'. Sorry about that.

Will be in sugar-toolkit 0.96.1 and is already in sugar-toolkit-gtk3 0.96.0

comment:9 Changed 8 years ago by dnarvaez

  • Component changed from sugar-toolkit to Sugar

comment:10 Changed 8 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.