Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#3499 closed defect (fixed)

Easy way to clear the url entry

Reported by: erikos Owned by: humitos
Priority: Normal Milestone:
Component: Browse Version: Git as of bugdate
Severity: Minor Keywords: patch
Cc: garycmartin, manuq Distribution/OS: OLPC
Bug Status: New

Description

In Browse I was looking for an easy way to clear the url entry, so that I can type a new url. In iOS you have a button at the right to do this (screenshot attached). The 'x' button is slightly different than the 'x' for stop loading of a page.

Attachments (8)

clear_url_field.PNG (10.4 KB) - added by erikos 9 years ago.
use the 'x' to clear the url entry
stop_loading.PNG (14.4 KB) - added by erikos 9 years ago.
use the 'x' to stop loading
browse-dialog-cancel.svg (1.1 KB) - added by manuq 9 years ago.
Proposal new icon for the stop loading button
0001-Graphic-for-the-cancel-loading-and-load-refresh-butt.patch (5.1 KB) - added by manuq 9 years ago.
browse-dialog-cancel.2.svg (1.1 KB) - added by manuq 9 years ago.
load cancel icon
browse-view-refresh.svg (1.3 KB) - added by manuq 9 years ago.
0001-Button-to-clear-the-url-entry-SL-3499.patch (3.6 KB) - added by humitos 9 years ago.
0001-Button-to-clear-the-url-entry-SL-3499.2.patch (4.0 KB) - added by humitos 9 years ago.
v2 - don't show icons on pdf tabs

Download all attachments as: .zip

Change History (28)

Changed 9 years ago by erikos

use the 'x' to clear the url entry

Changed 9 years ago by erikos

use the 'x' to stop loading

comment:1 Changed 9 years ago by erikos

  • Cc manuq added

comment:2 Changed 9 years ago by callkalpa

So we need two separate buttons. One to stop loading and the other to clear the URL box.

comment:3 follow-up: Changed 9 years ago by garycmartin

Just to clarify, the option to clear the url field should only appear when the url input has focus (e.g. you click/tap it to efit, or issue the keyboard shortcut ctrl-L). In the place where the little stop page loading icon would be, should be our standard clear field icon (grey circle with while x inside). Once you press the clear field icon, the field should be blanked and the clear field icon disappear (only to reappear once you start typing some text).

comment:4 in reply to: ↑ 3 ; follow-up: Changed 9 years ago by erikos

Replying to garycmartin:

Just to clarify, the option to clear the url field should only appear when the url input has focus (e.g. you click/tap it to efit, or issue the keyboard shortcut ctrl-L). In the place where the little stop page loading icon would be, should be our standard clear field icon (grey circle with while x inside). Once you press the clear field icon, the field should be blanked and the clear field icon disappear (only to reappear once you start typing some text).

Correct, that would be the desired behavior in my opinion. And the general behavior is good with you? Should we use similar icons as on iOS (see screenshots)?

comment:5 in reply to: ↑ 4 ; follow-up: Changed 9 years ago by garycmartin

Replying to erikos:

Replying to garycmartin:

Just to clarify, the option to clear the url field should only appear when the url input has focus (e.g. you click/tap it to efit, or issue the keyboard shortcut ctrl-L). In the place where the little stop page loading icon would be, should be our standard clear field icon (grey circle with while x inside). Once you press the clear field icon, the field should be blanked and the clear field icon disappear (only to reappear once you start typing some text).

Correct, that would be the desired behavior in my opinion. And the general behavior is good with you? Should we use similar icons as on iOS (see screenshots)?

Yes, and the icons are already very similar to the ones iOS used - my only suggestion would be that we consider a square stop icon, to stop a loading page, rather than the current grey x (which we use to close tabs and close control panels).

Changed 9 years ago by manuq

Proposal new icon for the stop loading button

comment:6 Changed 9 years ago by manuq

I attached a proposal for a stop loading button icon with a black square background. If Gary approves, there is a patch sent to the list.

comment:7 Changed 9 years ago by manuq

Also see old enhacement proposal in #1511 .

comment:8 in reply to: ↑ 5 Changed 9 years ago by erikos

Replying to garycmartin:

Replying to erikos:

Replying to garycmartin:

Just to clarify, the option to clear the url field should only appear when the url input has focus (e.g. you click/tap it to efit, or issue the keyboard shortcut ctrl-L). In the place where the little stop page loading icon would be, should be our standard clear field icon (grey circle with while x inside). Once you press the clear field icon, the field should be blanked and the clear field icon disappear (only to reappear once you start typing some text).

Correct, that would be the desired behavior in my opinion. And the general behavior is good with you? Should we use similar icons as on iOS (see screenshots)?

Yes, and the icons are already very similar to the ones iOS used - my only suggestion would be that we consider a square stop icon, to stop a loading page, rather than the current grey x (which we use to close tabs and close control panels).

Hmm, if you change the stop icon you would need to change the reload one as well, otherwise it looks strange. To me the simple 'x' and 'reload' icon do match nicely together.

As you say, our 'dialog-cancel' icon is already the same as the one in iOS, we can keep that. See #3385 though, for an issue adding that to an entry.

comment:9 Changed 9 years ago by manuq

Attached a patch that adds the square background to both icons.

Changed 9 years ago by manuq

load cancel icon

Changed 9 years ago by manuq

comment:10 follow-up: Changed 9 years ago by garycmartin

After testing the square based options for browse-dialogue-cancel and browse-view-refresh icons I'd like to reject my suggestion we consider a square stop icon (aka browse-dialogue-cancel). The existing stroke based browse icons are the least intrusive (as they make best use of the space without feeling cramped), and we should use sugar-artwork dialogue-cancel for clearing the url entry (or its equivalent icon fixing the wrong size bug #3385).

comment:11 in reply to: ↑ 10 Changed 9 years ago by manuq

Replying to garycmartin:

After testing the square based options for browse-dialogue-cancel and browse-view-refresh icons I'd like to reject my suggestion we consider a square stop icon (aka browse-dialogue-cancel). The existing stroke based browse icons are the least intrusive (as they make best use of the space without feeling cramped), and we should use sugar-artwork dialogue-cancel for clearing the url entry (or its equivalent icon fixing the wrong size bug #3385).

Yeah, fine for me too.

comment:12 Changed 9 years ago by humitos

  • Priority changed from Unspecified by Maintainer to Normal

comment:13 Changed 9 years ago by humitos

  • Owner changed from erikos to humitos
  • Status changed from new to accepted

comment:14 Changed 9 years ago by humitos

I've just attached a patch with this behaviour. Although I'm not happy with the icon to clear the url.

Manuq and Gary, can you take a look at my patch and suggest a new icon?

comment:15 Changed 9 years ago by humitos

  • Keywords patch added

comment:16 Changed 9 years ago by manuq

Works great humitos. Only exception should be the tabs displaying PDF. They have not editable entries, so the button to clear text should not be displayed for them.

comment:17 Changed 9 years ago by manuq

Also we should use the 'dialog-cancel' icon as per Gary comment 11.

Changed 9 years ago by humitos

v2 - don't show icons on pdf tabs

comment:18 follow-up: Changed 9 years ago by manuq

  • Resolution set to fixed
  • Status changed from accepted to closed

Found this: the text clear button should dissapear when there is no text in the entry. After you click on it, for example. See the search entries in sugar for reference.

But we can follow up that in another ticket, pushed as af31a44d . Thanks.

comment:19 in reply to: ↑ 18 Changed 9 years ago by humitos

Replying to manuq:

Found this: the text clear button should dissapear when there is no text in the entry. After you click on it, for example. See the search entries in sugar for reference.

Followed in #3968

comment:20 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.