#3476 closed defect (fixed)
Browse: wrong text in the url entry for new tab
Reported by: | manuq | Owned by: | manuq |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | |
Component: | Browse | Version: | Unspecified |
Severity: | Unspecified | Keywords: | 12.1.0 |
Cc: | Distribution/OS: | Unspecified | |
Bug Status: | Unconfirmed |
Description
If a new tab is opened via the + button or the shortcut, the text in the url is "Untitled", should be an empty string. Otherwise, hitting Enter key searches for "Untitled" in Google.
Attachments (2)
Change History (8)
comment:1 Changed 11 years ago by manuq
- Milestone changed from Unspecified by Release Team to 0.96
Changed 11 years ago by callkalpa
Changed 11 years ago by callkalpa
comment:2 follow-up: ↓ 3 Changed 11 years ago by manuq
comment:3 in reply to: ↑ 2 Changed 11 years ago by callkalpa
Replying to manuq:
Thanks callkalpa, your second patch is closer. As you noticed, _set_address method of PrimaryToolbar class was being called with uri == None.
In the other case, however, you changed to use "type(uri)", that gives error.
I'm sending a patch to the list.
Thanks manuq
Actually I used type() to see what uri really is at that point of execution, But I have forgotten to remove when I did the diff.
Your patch at the mail is solving the issue for me.
comment:4 Changed 11 years ago by manuq
Great, thanks for testing!
comment:5 Changed 11 years ago by manuq
- Resolution set to fixed
- Status changed from new to closed
Pushed: 0aab5f8300aaa18666bab748f457ccf295f68f52
Thanks callkalpa, your second patch is closer. As you noticed, _set_address method of PrimaryToolbar class was being called with uri == None.
In the other case, however, you changed to use "type(uri)", that gives error.
I'm sending a patch to the list.