Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#3445 closed defect (fixed)

Add comment to .PO file on getting localized Google search, also please release with new translations

Reported by: HoboPrimate Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Browse Version: Unspecified
Severity: Unspecified Keywords: 12.1.0, patch, olpc-test-passed
Cc: manuq, humitos Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Hi,
I've updated the translation for Browse, finally figured out how to make google search page be in portuguese: I added "hl=pt&" in the middle of the url, right after "http://www.google.com/search?". Could you add a Comment on the .PO file about this place to add the language?
And also, could you release a new version of Browse with the updated translation?
Thanks

Attachments (3)

Change History (14)

comment:1 Changed 9 years ago by manuq

  • Cc manuq added
  • Milestone changed from Unspecified by Release Team to 0.96

Changed 9 years ago by humitos

comment:2 Changed 9 years ago by humitos

  • Cc humitos added
  • Keywords patch added

comment:3 Changed 9 years ago by humitos

The comment was "stolen" from the Epiphany source code:

comment:5 follow-up: Changed 9 years ago by HoboPrimate

I would prefer the use of hl=LANG, the language a person is using with sugar won't necessarily mean they are living in the language's native country, and there may be other cases, like what happens with European Portuguese, where other countries have it as one of their official languages but have their own country-specific google page (São Tomé e Príncipe = google.st).

comment:6 in reply to: ↑ 5 Changed 9 years ago by manuq

Replying to HoboPrimate:

I would prefer the use of hl=LANG, the language a person is using with sugar won't necessarily mean they are living in the language's native country, and there may be other cases, like what happens with European Portuguese, where other countries have it as one of their official languages but have their own country-specific google page (São Tomé e Príncipe = google.st).

Yes, and that's what latest humitos patch does.

comment:7 Changed 9 years ago by HoboPrimate

Oh, sorry.

comment:8 Changed 9 years ago by humitos

Here you are a test case:

  1. Go to "My settings"
  2. Click on "Language"
  3. Change it to some one different that you have (it could be Portuguese for example)
  4. Save this option
  5. Open Browse
  6. Write something in the url like "I'm doing a search in google :)"

Expected behavior (after applying this patch)
The search results should be displayed in Portuguese

comment:9 Changed 9 years ago by manuq

  • Keywords 12.1.0 olpc-test-pending added
  • Resolution set to fixed
  • Status changed from new to closed

Pushed as ebb013347fcf777401c589a557c50fae8b7eb7e7 .

comment:10 Changed 9 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

The Google search matches the current set language in Browse-137 in 12.1.0 os10 for searches done in the title bar only (instead of entering URLs).

The OLPC custom homepage's Google search form still searches only in English.

comment:11 Changed 8 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.