Opened 9 years ago

Closed 9 years ago

#3419 closed defect (fixed)

Consider dropping libxml2 usage

Reported by: dsd Owned by: humitos
Priority: Low Milestone: Unspecified
Component: GetBooks Version: Unspecified
Severity: Unspecified Keywords:
Cc: humitos Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

GetBooks uses libxml2-python, and this is an external library.

Could it be switched to using the xml classes that are included in Python? This way we could consider dropping the libxml2-python usage from the sugar platform and OLPC builds.

Attachments (2)

0001-Drop-libxml2-SL-3419.patch (3.0 KB) - added by humitos 9 years ago.
0001-Drop-libxml2-SL-3419.2.patch (3.0 KB) - added by humitos 9 years ago.
New version - v2

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by humitos

  • Cc humitos added

Changed 9 years ago by humitos

comment:2 Changed 9 years ago by godiard

We need do the following tests:

  • Navigate the catalog: Click on "public domain books",and select different categories, up and down. The list of books should be updated.
  • When click in any book, the image and data in the bottom side of the screen should be updated.
  • Download the book. Try different formats if available.
  • Search a title or author.
  • Change the source combo to "Internet Archive" and do a search.
  • Download a book from Internet Archive.

comment:3 Changed 9 years ago by humitos

All of this test that you mentioned here passed without any problem after applying this patch.

comment:4 Changed 9 years ago by humitos

  • Owner changed from godiard to humitos
  • Status changed from new to accepted

Changed 9 years ago by humitos

New version - v2

comment:5 Changed 9 years ago by godiard

  • Resolution set to fixed
  • Status changed from accepted to closed

I can't see any change in your second patch.

I applied a version with the changes we talked (move _xmldoc and _eroot to get_full_language_name method, and make them method variables)

Note: See TracTickets for help on using tickets.