Opened 7 years ago

Last modified 5 years ago

#3412 assigned enhancement

Use gtk_accelerator_parse() instead of egg for key handling

Reported by: dsd Owned by: erikos
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords: patch
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

When porting the shell to GTK3, we can simplify the key grabbing (for Frame key, etc) code in sugar-toolkit-gtk3.

We currently include eggaccelerators.c from libegg just to parse key names into codes that can be grabbed. This is now provided by GTK+ in the form of gtk_accelerator_parse() or its more flexible variant gtk_accelerator_parse_with_keycode(). We can switch to that and remove the egg code.

https://bugzilla.gnome.org/show_bug.cgi?id=672950

Change History (4)

comment:1 Changed 7 years ago by erikos

  • Milestone changed from Unspecified by Release Team to 0.98
  • Owner set to erikos
  • Status changed from new to assigned

comment:2 Changed 7 years ago by erikos

  • Milestone changed from 0.98 to 1.0

Moving out, as this is just a cleanup. Ack'ed by dsd.

comment:3 Changed 6 years ago by dnarvaez

  • Milestone changed from 1.0 to Unspecified
Note: See TracTickets for help on using tickets.