Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3387 closed defect (fixed)

Artifacts in share buttons

Reported by: godiard Owned by: erikos
Priority: High Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Major Keywords: 12.1.0, patch, olpc-test-passed
Cc: Distribution/OS: OLPC
Bug Status: Assigned

Description

In os5 with the last sugar-artwork/toolkit rpm, the icons in the share toolbar are not displayed ok in a gtk3 activity (Read).

The gtk2 activities are ok, and the same gtk3 activity show the icons ok in my F16 devel env.

Attachments (7)

Captura_share_button_gtk3.png (441.3 KB) - added by godiard 8 years ago.
Captura_share_button_gtk_hover.png (443.0 KB) - added by godiard 8 years ago.
The same icon when the mouse is over it
share_palette.png (21.5 KB) - added by erikos 8 years ago.
share palette in gtk2
share_palette_shared.png (23.0 KB) - added by erikos 8 years ago.
shared palette in gtk2: when shared the buttons become inactive (becasue one can not unshare other than closing the activity)
0001-Improve-theming-of-share-buttons.patch (1.2 KB) - added by garnacho 8 years ago.
Partial fix, improve theming of share buttons
0001-Improve-theming-of-toggle-buttons-in-toolbars.patch (2.2 KB) - added by garnacho 8 years ago.
patch
0001-Fix-artifacts-in-share-button-SL-3387.patch (2.3 KB) - added by erikos 8 years ago.
Patch to fix the artifacts in teh share button

Download all attachments as: .zip

Change History (22)

Changed 8 years ago by godiard

Changed 8 years ago by godiard

The same icon when the mouse is over it

comment:1 Changed 8 years ago by erikos

  • Distribution/OS changed from Unspecified to OLPC
  • Milestone changed from Unspecified by Release Team to 0.96
  • Severity changed from Unspecified to Major

comment:2 Changed 8 years ago by erikos

  • Keywords 12.1.0 added

One of the issues here is that in radiotoolbutton we still have code that is using 'do_expose_event' instead of 'do_draw', this has to be ported.

Changed 8 years ago by erikos

share palette in gtk2

Changed 8 years ago by erikos

shared palette in gtk2: when shared the buttons become inactive (becasue one can not unshare other than closing the activity)

comment:3 Changed 8 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Priority changed from Unspecified by Maintainer to High
  • Version changed from Unspecified to Git as of bugdate

First part of the issue:

The white square which can be seen in the sharing palette instead of the home view icon is because the background-color for a widget in the active state is set to white in the theme by default: http://git.sugarlabs.org/sugar-artwork/mainline/blobs/master/gtk3/theme/gtk-widgets.css.em#line123 The widget is in the active state at that moment. We have to see now if we need that gloabl background setting and what uses it, maybe it can be more specialized.

Changed 8 years ago by garnacho

Partial fix, improve theming of share buttons

comment:4 Changed 8 years ago by garnacho

The attached patch improves the theming color wise (I don't know of any gtk2 activity to compare it with though), but triggers some weird resizing of the palette window. I've yet to investigate where do those come from, it looks like either:

  • some css rules specificity bug (there don't seem to be rules that should mess with padding/margin)
  • something in the code triggering a queue_resize() with strange values, the bigger rectangle over the active&hovered item might stretch things, and isn't drawn by the GtkRadioToolButton child itself

comment:5 Changed 8 years ago by garnacho

Doh! I completely oversaw a cluster of rules that could override certain values, I'm attaching another patch, which coincidentally fixes http://bugs.sugarlabs.org/ticket/3590 as well

Changed 8 years ago by erikos

Patch to fix the artifacts in teh share button

comment:6 Changed 8 years ago by erikos

  • Keywords patch added

comment:7 Changed 8 years ago by erikos

  • Keywords olpc-test-pending added
  • Resolution set to fixed
  • Status changed from new to closed

I pushed the patch now with a more detailed description as: http://git.sugarlabs.org/sugar-artwork/mainline/commit/54ef96860a93eb5c95ea019c12cd4dc388117398 after I got green testing light from Gonzalo, will be in 0.96.3.

I think the issue described here is fixed now and we have the same appearance as with the old toolkit. As an enhancement, we might want to highlight the neighborhood icon when hovering over it:

SugarPaletteWindowWidget SugarRadioToolButton *:hover {
    background-color: @button_grey;                                                                                                                                                      
    border-radius: $(toolbutton_padding)px;                                                                                                                                           
}

comment:8 Changed 8 years ago by greenfeld

  • Keywords olpc-test-pending removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

I can exactly reproduce the problem shown in the Captura_share_button_gtk3.png and Captura_share_button_gtk_hover.png files, so this does not seem to be fixed.

comment:9 Changed 8 years ago by greenfeld

  • Keywords olpc-test-pending added
  • Resolution set to fixed
  • Status changed from reopened to closed

Actually I take that back; may not be in the build yet as of os11.

comment:10 Changed 8 years ago by greenfeld

  • Keywords olpc-test-pending removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

This still does not seem to be fixed in 12.1.0 os13.

comment:11 Changed 8 years ago by erikos

Works fine for me in os13, which has artwork-0.93 which has the fix.

comment:12 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added
  • Resolution set to fixed
  • Status changed from reopened to closed

The fix is in 12.1.0 os14/os15, but according to http://build.laptop.org/12.1.0/os13/xo-1.5/21013o1.packages.txt os13 still had sugar-artwork-0.96.2.

comment:13 Changed 8 years ago by erikos

Ok, I see now - I checked on the 1.75 where the 0.93 release was available on the 1.5 you are right it was still 0.92 in the os13 build. An issue introduced by the infrastructural differences.

comment:14 Changed 7 years ago by dnarvaez

  • Component changed from sugar-toolkit-gtk3 to Sugar

comment:15 Changed 7 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.