Journal fails to load if a single activity icon is broken

[sascha_silbe]

If a single activity icon is broken, Journal will die on an uncaught GError in jarabe.journal.journaltoolbox.refresh_filters() while filling the "what" filter combo box.

Test case:

1. Install the attached bundle.
2. Start the just installed HelloWorldBrokenIcon activity using the Activities list view (the Ring / Spiral view will not work because of the broken icon).
3. Restart Sugar.
4. Verify that the Journal starts up.

[sascha_silbe]

HelloWorld activity with broken icon

[erikos]

Ok, I installed your activity, and did start Sugar. The activity icon is not displayable in the activity list of home view and the log does show the error you describing:

Traceback (most recent call last):
  File "/home/erikos/sugar-jhbuild/install/lib/python2.7/site-packages/sugar/graphics/icon.py", line 1155, in on_render
    surface = self._buffer.get_surface()
  File "/home/erikos/sugar-jhbuild/install/lib/python2.7/site-packages/sugar/graphics/icon.py", line 262, in get_surface
    handle = self._load_svg(icon_info.file_name)
  File "/home/erikos/sugar-jhbuild/install/lib/python2.7/site-packages/sugar/graphics/icon.py", line 121, in _load_svg
    return self._loader.load(file_name, entities, self.cache)
  File "/home/erikos/sugar-jhbuild/install/lib/python2.7/site-packages/sugar/graphics/icon.py", line 66, in load
    return rsvg.Handle(data=icon)
glib.GError: Error domain 1 code 76 on line 27 column 11 of data: Opening and ending tag mismatch: svg line 0 and svgX

and

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/dbus/connection.py", line 214, in maybe_handle_message
    self._handler(*args, **kwargs)
  File "/home/erikos/sugar-jhbuild/install/lib/python2.7/site-packages/jarabe/journal/model.py", line 507, in _datastore_created_cb
    created.send(None, object_id=object_id)
  File "/home/erikos/sugar-jhbuild/install/lib/python2.7/site-packages/sugar/dispatch/dispatcher.py", line 125, in send
    response = receiver(signal=self, sender=sender, **named)
  File "/home/erikos/sugar-jhbuild/install/lib/python2.7/site-packages/jarabe/journal/journalactivity.py", line 260, in __model_created_cb
    self._main_toolbox.search_toolbar.refresh_filters()
  File "/home/erikos/sugar-jhbuild/install/lib/python2.7/site-packages/jarabe/journal/journaltoolbox.py", line 326, in refresh_filters
    file_name=activity_info.get_icon())
  File "/home/erikos/sugar-jhbuild/install/lib/python2.7/site-packages/sugar/graphics/combobox.py", line 117, in append_item
    file_name, width, height)
GError: Error writing
Traceback (most recent call last):

I still can use the Journal fine, it did not die for me. Anything else you need to do to make it die?

[erikos]

logs when the Journal dies (you need to start the broken activity once and then start Sugar again)

[sascha_silbe]

Updated test case. You need to run the activity and restart Sugar in order to trigger the bug.

[erikos]

Has been pushed: ​http://git.sugarlabs.org/sugar/mainline/commit/e72ebf7513c89c3ba91f606ab11537ce5a556fde

#3203 is filed to solve the other areas (activity list, home view, palette...) that are affected by a broken icon.

[greenfeld]

The attached activity does not break 12.1.0 os8.

[dnarvaez]

Milestone 0.94 deleted