add a way to add new contacts not seen by the PS

[tomeu]

This patch is a first step towards implementing this feature, though there's lots of work still to do.

[gdesmott]

Some comments:

• imports should be done at the begin of the file

• there should have UI asking for the identifier to add (instead of hardcoding "tomeu-test@…")

• UI should also list the existing TP connections and let the user choose the one to which the contact have to be added (instead of taking the first connection from conn_watcher.get_connections())

• You should use the new Requests API. Something like that:

channel_path, props = connection[CONNECTION_INTERFACE_REQUESTS].EnsureChannel(
CHANNEL_INTERFACE + ".ChannelType": CHANNEL_TYPE_CONTACT_LIST,
CHANNEL_INTERFACE + ".TargetHandleType": CONNECTION_HANDLE_TYPE_LIST,
CHANNEL_INTERFACE + ".TargetID": 'subscribe')

So you don't need to request the subscribe handle any more.

• You should probably add the contact to the 'publish' contact list too. Maybe that should be done once the contact accepted your request but we can start like that for now.

See also ​https://dev.laptop.org/ticket/8841 where Rob described what should be done to properly manager buddy subscriptions.

[tomeu]

Replying to gdesmott:

Some comments:

• imports should be done at the begin of the file

• there should have UI asking for the identifier to add (instead of hardcoding "tomeu-test@…")

• UI should also list the existing TP connections and let the user choose the one to which the contact have to be added (instead of taking the first connection from conn_watcher.get_connections())

Sure, this patch wasn't proposed for inclusion, just attached it for reference when we get to actually implement this feature.

• You should use the new Requests API. Something like that:

channel_path, props = connection[CONNECTION_INTERFACE_REQUESTS].EnsureChannel(
CHANNEL_INTERFACE + ".ChannelType": CHANNEL_TYPE_CONTACT_LIST,
CHANNEL_INTERFACE + ".TargetHandleType": CONNECTION_HANDLE_TYPE_LIST,
CHANNEL_INTERFACE + ".TargetID": 'subscribe')

So you don't need to request the subscribe handle any more.

• You should probably add the contact to the 'publish' contact list too. Maybe that should be done once the contact accepted your request but we can start like that for now.

That's good to know, thanks!

See also ​https://dev.laptop.org/ticket/8841 where Rob described what should be done to properly manager buddy subscriptions.

That's good info, will enter individual tickets for the smaller pieces.

[dnarvaez]

Given the issues we have with the collaboration framework I don't think this is a priority.

[dnarvaez]

Milestone 0.90 deleted