Opened 8 years ago

Closed 20 months ago

#3132 closed enhancement (duplicate)

Memorize should have latest speak update

Reported by: RafaelOrtiz Owned by: godiard
Priority: Normal Milestone: Unspecified
Component: Memorize Version: Unspecified
Severity: Major Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

As memorize uses speak code, it should be using latest code available there.

Change History (6)

comment:1 Changed 8 years ago by erikos

  • Owner changed from erikos to godiard
  • Status changed from new to assigned

comment:2 Changed 8 years ago by godiard

Can you explain what change and why is important?

comment:3 Changed 8 years ago by RafaelOrtiz

Latest speak code recognizes AU english and other english variants, and if system has the AU locale sets the combo to english_rp, also it has some minor pep8 fixes.


comment:4 Changed 7 years ago by humitos

In the latest Sugar version speak is integrated with Sugar (at the bottom right), so maybe we can delete the speak code from Memorize and use the same code that sugar uses.

Is this possible? Am I wrong?

comment:5 Changed 7 years ago by godiard

In the latest Sugar version speak is integrated with Sugar (at the bottom right), so maybe we can delete the speak code from Memorize and use the same code that sugar uses.
Is this possible? Am I wrong?

No yet. The speech code is in sugar, but not in sugar-toolkit, and the activities can include sugar-toolkit, but not sugar code. The plan is work in moving part of the speech sugar code to sugar-toolkit in sugar 0.98 timeframe, then we will be available to remove the code in memorize, words, speak and a few more.

comment:6 Changed 20 months ago by quozl

  • Resolution set to duplicate
  • Status changed from assigned to closed

Speech code is now in toolkit.

Moved to https://github.com/sugarlabs/memorize-activity/issues/8

Note: See TracTickets for help on using tickets.