Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3105 closed defect (fixed)

Paint: undo does not work reliably

Reported by: erikos Owned by: humitos
Priority: Unspecified by Maintainer Milestone:
Component: Paint Version: 0.93.x
Severity: Unspecified Keywords: 12.1.0, patch, olpc-test-passed
Cc: humitos Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

I have been using today Paint for a while and 'undo' has not been working for me reliably. Sometimes more than one step did get undone. For example I did color different areas (with the bucket tool) and then did press 'undo' and it jumped back too an older version and did not just undo the last step.

Paint version 36

Attachments (3)

0001-Undo-fixed-SL-3105.patch (1.2 KB) - added by humitos 8 years ago.
spin-undo-list-test.patch (5.1 KB) - added by humitos 8 years ago.
0001-Undo-after-using-bucket-tool-fixed-SL-3105.patch (1.8 KB) - added by humitos 8 years ago.
This patch solves this issue

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by humitos

  • Cc humitos added

Yes, I can confirm this. I've just tested it on XO 1.75 os12 and Undo is not working properly.

In fact, if you

  1. color different areas as erikos said
  2. press the Undo button
  3. color some new areas

The ability to Undo again is lost. You just can click on Redo and it does "something strange".

comment:2 Changed 8 years ago by humitos

  • Owner changed from godiard to humitos
  • Status changed from new to accepted

Changed 8 years ago by humitos

comment:3 Changed 8 years ago by humitos

  • Keywords patch added

This patch solves this issue, but there is a case that I couldn't find yet:

  1. Draw anything in 5 steps. For example, five lines
  2. Click twice on "Undo"
  3. Click once on "Redo"

The "Redo" action will not work. But if you press this button again you will see the "Redo" action done. I'm pretty sure that it's related with the index (self._undo_index) of the self._undo_list but I couldn't fix it yet.

Changed 8 years ago by humitos

comment:4 Changed 8 years ago by humitos

I added a patch that adds a new Spin Button to show every "undo item" in the self._undo_list. This is useful to test if the "undo item" is being shown or not.

I don't know why but every time that I use the bucket twice and click on "Undo" both of the fills are undone. After that when I press on "Redo" just the first one is redone.

Changed 8 years ago by humitos

This patch solves this issue

comment:5 Changed 8 years ago by manuq

  • Keywords 12.1.0 olpc-test-pending added
  • Milestone changed from Unspecified by Release Team to 0.96
  • Resolution set to fixed
  • Status changed from accepted to closed

Thanks! Pushed.

comment:6 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

Undo and redo support seems to work properly in Paint in 12.1.0 os18.

comment:7 Changed 7 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.