#3105 closed defect (fixed)
Paint: undo does not work reliably
Reported by: | erikos | Owned by: | humitos |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | |
Component: | Paint | Version: | 0.93.x |
Severity: | Unspecified | Keywords: | 12.1.0, patch, olpc-test-passed |
Cc: | humitos | Distribution/OS: | Unspecified |
Bug Status: | Unconfirmed |
Description
I have been using today Paint for a while and 'undo' has not been working for me reliably. Sometimes more than one step did get undone. For example I did color different areas (with the bucket tool) and then did press 'undo' and it jumped back too an older version and did not just undo the last step.
Paint version 36
Attachments (3)
Change History (10)
comment:1 Changed 11 years ago by humitos
- Cc humitos added
comment:2 Changed 11 years ago by humitos
- Owner changed from godiard to humitos
- Status changed from new to accepted
Changed 11 years ago by humitos
comment:3 Changed 11 years ago by humitos
- Keywords patch added
This patch solves this issue, but there is a case that I couldn't find yet:
- Draw anything in 5 steps. For example, five lines
- Click twice on "Undo"
- Click once on "Redo"
The "Redo" action will not work. But if you press this button again you will see the "Redo" action done. I'm pretty sure that it's related with the index (self._undo_index) of the self._undo_list but I couldn't fix it yet.
Changed 11 years ago by humitos
comment:4 Changed 11 years ago by humitos
I added a patch that adds a new Spin Button to show every "undo item" in the self._undo_list. This is useful to test if the "undo item" is being shown or not.
I don't know why but every time that I use the bucket twice and click on "Undo" both of the fills are undone. After that when I press on "Redo" just the first one is redone.
comment:5 Changed 11 years ago by manuq
- Keywords 12.1.0 olpc-test-pending added
- Milestone changed from Unspecified by Release Team to 0.96
- Resolution set to fixed
- Status changed from accepted to closed
Thanks! Pushed.
comment:6 Changed 11 years ago by greenfeld
- Keywords olpc-test-passed added; olpc-test-pending removed
Undo and redo support seems to work properly in Paint in 12.1.0 os18.
Yes, I can confirm this. I've just tested it on XO 1.75 os12 and Undo is not working properly.
In fact, if you
The ability to Undo again is lost. You just can click on Redo and it does "something strange".