Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#3076 closed enhancement (fixed)

Journal: add support for copying to Documents folder (detail view, copy-to palette)

Reported by: greenfeld Owned by: erikos
Priority: High Milestone:
Component: Sugar Version: 0.93.x
Severity: Major Keywords: r+, olpc-test-passed
Cc: humitos, erikos Distribution/OS: OLPC
Bug Status: Assigned

Description

The Journal item detail view can copy items to a USB stick (if inserted) and the Clipboard. But it cannot copy the currently active item to the Documents folder if said folder is available from the main Journal list view.

Seen in 11.3.0 os3.

Attachments (3)

0001-Copying-to-Documents-folder-SL-3076.patch (2.2 KB) - added by humitos 9 years ago.
This patch is not finished. I don't know how to get the "selected_volume" yet
0001-Copying-to-Documents-folder-SL-3076.2.patch (4.1 KB) - added by humitos 9 years ago.
v2 - adds the same behaviour on toolbox's icon
0001-Copying-to-Documents-folder-.v3-SL-3076.patch (3.9 KB) - added by godiard 8 years ago.
Add new version (v3) of patch, with the pending issue solved. Now only show the option when needed.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 10 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Keywords 11.3.0 removed
  • Severity changed from Unspecified to Major
  • Summary changed from Journal item detail view cannot copy to Documents folder to Journal: add support for copying to Documents folder (detail view, copy-to palette)
  • Type changed from defect to enhancement

Yes, this is known. Would be a bigger change to add support for that. Moving out to 0.96.

comment:2 Changed 10 years ago by erikos

  • Milestone changed from 0.94 to 0.96

comment:3 Changed 9 years ago by erikos

  • Milestone changed from 0.96 to 0.98

comment:4 Changed 9 years ago by erikos

  • Owner set to erikos
  • Status changed from new to assigned

comment:5 Changed 9 years ago by erikos

  • Cc humitos added

Changed 9 years ago by humitos

This patch is not finished. I don't know how to get the "selected_volume" yet

comment:6 Changed 9 years ago by erikos

  • Keywords r? added

Changed 9 years ago by humitos

v2 - adds the same behaviour on toolbox's icon

comment:7 Changed 9 years ago by humitos

I implemented this behaviour but the value of "selected_folder" variable is missing. I don't know how to (or from where) get it.

This patch adds the same code in two different files and that is not so good. Actually, there are repeated old code on those files that this patch touches.

comment:8 Changed 8 years ago by godiard

  • Priority changed from Unspecified by Maintainer to High

comment:9 Changed 8 years ago by godiard

  • Cc erikos added

Changed 8 years ago by godiard

Add new version (v3) of patch, with the pending issue solved. Now only show the option when needed.

comment:10 Changed 8 years ago by godiard

Simon, new patch version, I think ready to include.

comment:11 Changed 8 years ago by erikos

  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from assigned to closed

Pushed as b01cd3e080a0df6d046057c67b6fb7ff7b0daa63 Changed the icon to be black and white after discussing with Gary.

erikos: garycmartin: the document icon in the Palette, should it be owner-coloured or bw? 
garycmartin: erikos: re document icon in the Palette, owner-coloured or bw? Hmmmm, clip board and USB sticks are showing as B&W at the moment, so for now stick with B&W for the Documents folder, though I'd say really USB sticks and Documents folder should be in user colour (to matches how they are show in the journal volumes toolbar/frame).
erikos: garycmartin: yeah, I had similar thinking 
erikos: garycmartin: but clipboard, is my clipboard as well right?
erikos: garycmartin: why should that be bw?
garycmartin: erikos: The clipboard icon really doesn't work well in user colours, I tried once before, it's just a single fill colour with no outline.
erikos: garycmartin: ok, I feared such an answer
erikos: garycmartin: so, I would vote for bw for the document folder as well
erikos: garycmartin: to have a consistent Palette there
garycmartin: erikos: needs a new icon for that, and then raises the question if it should also be coloured in Activity toolbars...
garycmartin: erikos: +1

Thanks everyone!

comment:12 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

The copy-to-journal option exists in OLPC 13.1.0 os27.

comment:13 Changed 8 years ago by greenfeld

The copy-to-documents folder option rather.

comment:14 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.