Checkbox outline on black panel disappears in mouseover selection highlight

[erikos]

Agreed this should be changed, i will have a look.

[erikos]

Benjamin, is that something we can/should handle in the theme?

[FGrose]

This checkbox was used on the Home, Favorites view, Resume default, but that is option is no longer revealed. Don't know where another checkbox on a black panel is used currently, but the issue will return when that need arises, unless the graphic is tuned in the theme for this situation.

[erikos]

This is not a current issue anymore as the checkbox has been removed. However we should fix this as we might run into it again.

[sascha_silbe]

Bulk change distribution=SoaS -> component=SoaS

[sdz]

This is a Sugar issue that got accidentally assigned to SoaS during an auto-tag. Reassigning.

[ishan]

I am presently handling the bug- ​http://bugs.sugarlabs.org/ticket/305.

I have made the changes in the file sugar-100.gtkrc present under sugar-jhbuild/source/sugar-artworks/gtk/themes but it seems that while making the patch, git does not identifies such files so we have to add the file manually using git add -f sugar-100.gtkrc and commit the changes. But when the patch is made it shows the entire file as added in the patch file. For reference check ​http://pastebin.com/VE0TakJX which shows the patch file made.

Any suggestions on how can i just list the changes i made in the file instead of the entire file?

[sascha_silbe]

Replying to ishan:

I am presently handling the bug- ​http://bugs.sugarlabs.org/ticket/305.

I hope so if your commenting on exactly this ticket. ;)

I have made the changes in the file sugar-100.gtkrc present under sugar-jhbuild/source/sugar-artworks/gtk/themes but it seems that while making the patch, git does not identifies such files so we have to add the file manually using git add -f sugar-100.gtkrc and commit the changes. But when the patch is made it shows the entire file as added in the patch file. For reference check ​http://pastebin.com/VE0TakJX which shows the patch file made.

Please attach files to the ticket instead of mentioning a pastebin URL. Attachments will stay available, whereas pastebin regularly erases content. I have confirmed your user account, so you should be able to attach files in the future.

As to your problem, sugar-72.gtkrc and sugar-100.gtkrc are automatically created from gtkrc.em during the build process. Check out ​gtk/theme/Makefile.am. You need to change the source file (gtkrc.em) instead.

[benzea]

OK, never reacted earlier ...

Unfortunately I am not running any remotely recent version of sugar anywhere right now, so I am not going to look more closely into this. It should be relativel simple to change the color in general, the question is under what circumstances.
ie. how is the background color changed on the black panel, and is there a sane way for the theme to know that this happened (or maybe it already knows, but the style to change the color in the checkbox is just missing). Unfortunately it is hard to tell anything from the pastebin post, as it contains the whole file, and I am not familiar enough with the theme currently.

[smparrish]

Replying to sascha_silbe:

Replying to ishan:

I am presently handling the bug- ​http://bugs.sugarlabs.org/ticket/305.

I hope so if your commenting on exactly this ticket. ;)

I have made the changes in the file sugar-100.gtkrc present under sugar-jhbuild/source/sugar-artworks/gtk/themes but it seems that while making the patch, git does not identifies such files so we have to add the file manually using git add -f sugar-100.gtkrc and commit the changes. But when the patch is made it shows the entire file as added in the patch file. For reference check ​http://pastebin.com/VE0TakJX which shows the patch file made.

Please attach files to the ticket instead of mentioning a pastebin URL. Attachments will stay available, whereas pastebin regularly erases content. I have confirmed your user account, so you should be able to attach files in the future.

As to your problem, sugar-72.gtkrc and sugar-100.gtkrc are automatically created from gtkrc.em during the build process. Check out ​gtk/theme/Makefile.am. You need to change the source file (gtkrc.em) instead.

Ishan as Sascha pointed out you have modified the wrong file. sugar-100.gtkrc is created during the build process so your changes will never be applied. You need to Check out ​gtk/theme/Makefile.am. You need to change the source file (gtkrc.em) instead.

Please work with gtkrc.em and submit an updated patch.

Thanks

Steven Parrish
Dextrose Project Manager

[ishan]

Steven

I have already made the patch using gtkrc.em .

Please refer to ​http://lists.sugarlabs.org/archive/sugar-devel/2010-September/026732.html
to review the patch.