Opened 11 years ago

Last modified 5 years ago

#305 assigned defect

Checkbox/Radio button outline on black panel disappears in mouseover selection highlight

Reported by: FGrose Owned by: erikos
Priority: Normal Milestone: 0.102.0
Component: Sugar Version: 0.98.x
Severity: Major Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: New

Description (last modified by FGrose)

Observed in Soas-200902041922.iso (and earlier versions).

The gray outline of the checkbox disappears into the gray highlight of the mouseover selection.

This is an unexpected loss of focus for the user.

A white, lighter or darker gray outline could be used or revealed on the highlight action to visually polish this panel.

The uncheck action highlight is OK.

Attachments (3)

sugar-100.gtkrc (19.2 KB) - added by ishan 9 years ago.
screenshot.png (41.7 KB) - added by benzea 9 years ago.
screenshot of the software update list
gray radio button.png (55.2 KB) - added by FGrose 9 years ago.

Download all attachments as: .zip

Change History (30)

comment:1 Changed 11 years ago by erikos

  • Bug Status changed from Unconfimed to Assigned
  • Milestone changed from Unspecified by Release Team to 0.84
  • Owner changed from marcopg to erikos
  • Priority changed from Unspecified by Maintainer to High
  • Severity changed from Unspecified to Major
  • Status changed from new to assigned

Agreed this should be changed, i will have a look.

comment:2 Changed 11 years ago by erikos

  • Cc benjamin@… added

Benjamin, is that something we can/should handle in the theme?

comment:3 Changed 11 years ago by FGrose

  • Summary changed from Home, Favorites view, Resume default checkbox outline disappears on mouseover selection highlight to Checkbox outline on black panel disappears in mouseover selection highlight

This checkbox was used on the Home, Favorites view, Resume default, but that is option is no longer revealed. Don't know where another checkbox on a black panel is used currently, but the issue will return when that need arises, unless the graphic is tuned in the theme for this situation.

comment:4 Changed 11 years ago by erikos

  • Milestone changed from 0.84 to 0.86

This is not a current issue anymore as the checkbox has been removed. However we should fix this as we might run into it again.

comment:5 Changed 11 years ago by homunq

  • Keywords sugar-love added

comment:6 Changed 10 years ago by sascha_silbe

  • Component changed from sugar to SoaS
  • Distribution/OS changed from SoaS to Unspecified

Bulk change distribution=SoaS -> component=SoaS

comment:7 Changed 9 years ago by sdz

  • Component changed from SoaS to sugar

This is a Sugar issue that got accidentally assigned to SoaS during an auto-tag. Reassigning.

comment:8 follow-up: Changed 9 years ago by ishan

I am presently handling the bug- http://bugs.sugarlabs.org/ticket/305.

I have made the changes in the file sugar-100.gtkrc present under sugar-jhbuild/source/sugar-artworks/gtk/themes but it seems that while making the patch, git does not identifies such files so we have to add the file manually using git add -f sugar-100.gtkrc and commit the changes. But when the patch is made it shows the entire file as added in the patch file. For reference check http://pastebin.com/VE0TakJX which shows the patch file made.

Any suggestions on how can i just list the changes i made in the file instead of the entire file?

comment:9 in reply to: ↑ 8 ; follow-up: Changed 9 years ago by sascha_silbe

Replying to ishan:

I am presently handling the bug- http://bugs.sugarlabs.org/ticket/305.

I hope so if your commenting on exactly this ticket. ;)

I have made the changes in the file sugar-100.gtkrc present under sugar-jhbuild/source/sugar-artworks/gtk/themes but it seems that while making the patch, git does not identifies such files so we have to add the file manually using git add -f sugar-100.gtkrc and commit the changes. But when the patch is made it shows the entire file as added in the patch file. For reference check http://pastebin.com/VE0TakJX which shows the patch file made.

Please attach files to the ticket instead of mentioning a pastebin URL. Attachments will stay available, whereas pastebin regularly erases content. I have confirmed your user account, so you should be able to attach files in the future.

As to your problem, sugar-72.gtkrc and sugar-100.gtkrc are automatically created from gtkrc.em during the build process. Check out gtk/theme/Makefile.am. You need to change the source file (gtkrc.em) instead.

comment:10 Changed 9 years ago by benzea

OK, never reacted earlier ...

Unfortunately I am not running any remotely recent version of sugar anywhere right now, so I am not going to look more closely into this. It should be relativel simple to change the color in general, the question is under what circumstances.
ie. how is the background color changed on the black panel, and is there a sane way for the theme to know that this happened (or maybe it already knows, but the style to change the color in the checkbox is just missing). Unfortunately it is hard to tell anything from the pastebin post, as it contains the whole file, and I am not familiar enough with the theme currently.

Changed 9 years ago by ishan

comment:11 in reply to: ↑ 9 Changed 9 years ago by smparrish

Replying to sascha_silbe:

Replying to ishan:

I am presently handling the bug- http://bugs.sugarlabs.org/ticket/305.

I hope so if your commenting on exactly this ticket. ;)

I have made the changes in the file sugar-100.gtkrc present under sugar-jhbuild/source/sugar-artworks/gtk/themes but it seems that while making the patch, git does not identifies such files so we have to add the file manually using git add -f sugar-100.gtkrc and commit the changes. But when the patch is made it shows the entire file as added in the patch file. For reference check http://pastebin.com/VE0TakJX which shows the patch file made.

Please attach files to the ticket instead of mentioning a pastebin URL. Attachments will stay available, whereas pastebin regularly erases content. I have confirmed your user account, so you should be able to attach files in the future.

As to your problem, sugar-72.gtkrc and sugar-100.gtkrc are automatically created from gtkrc.em during the build process. Check out gtk/theme/Makefile.am. You need to change the source file (gtkrc.em) instead.

Ishan as Sascha pointed out you have modified the wrong file. sugar-100.gtkrc is created during the build process so your changes will never be applied. You need to Check out gtk/theme/Makefile.am. You need to change the source file (gtkrc.em) instead.

Please work with gtkrc.em and submit an updated patch.

Thanks

Steven Parrish
Dextrose Project Manager

comment:12 Changed 9 years ago by ishan

  • Description modified (diff)

Steven

I have already made the patch using gtkrc.em .

Please refer to http://lists.sugarlabs.org/archive/sugar-devel/2010-September/026732.html
to review the patch.

comment:13 Changed 9 years ago by FGrose

  • Description modified (diff)

Restoring the original description (it got blanked out).

comment:14 Changed 9 years ago by smparrish

  • Cc smparrish added

comment:15 Changed 9 years ago by smparrish

  • seeta_dev set to Ishan

comment:16 Changed 9 years ago by benzea

Unconditionally changing the color seems quite intrusive to me.

Attaching a screenshot, is this the case where the problem arises?
(Note that at least one bug can be seen in the shot: the background of the checkbox should be white, but is not because of the treeviews style.)

Changed 9 years ago by benzea

screenshot of the software update list

comment:17 Changed 9 years ago by sascha_silbe

The original instance of this bug is gone, so we need a test case (a minimal GTK program) to reproduce it.
The existing patch looks like it would make the problem worse instead of fixing it, but only the test case can really show.

Changed 9 years ago by FGrose

comment:18 Changed 9 years ago by FGrose

  • Component changed from sugar to design
  • Summary changed from Checkbox outline on black panel disappears in mouseover selection highlight to Checkbox/Radio button outline on black panel disappears in mouseover selection highlight

An example of this styling problem is available in Browse by secondary-button-clicking in the address bar. See 'gray radio button' screenshot, attached.

comment:19 Changed 6 years ago by godiard

  • Cc benjamin@… smparrish removed
  • Component changed from design to sugar-artwork
  • Keywords sugar-love removed
  • Milestone changed from 0.86 to 1.0
  • Priority changed from High to Normal
  • Version changed from 0.83.x to 0.98.x

This happen again in sugar 0.98, and worst, the test case displayed on the last screenshot show a artifact in the radiobuttons.

comment:20 follow-up: Changed 6 years ago by benzea

But it is using GTK+ 3.x now, instead of 2.x?

I would say it is important to know in what widgets it happens. It should be pretty simple to specifically style the checkbox inside eg. a menu item. Not sure right now how this is done in GTK+ 3.x though.

comment:21 in reply to: ↑ 20 Changed 6 years ago by godiard

Replying to benzea:

But it is using GTK+ 3.x now, instead of 2.x?

I would say it is important to know in what widgets it happens. It should be pretty simple to specifically style the checkbox inside eg. a menu item. Not sure right now how this is done in GTK+ 3.x though.

Yes, using gtk3

comment:22 Changed 6 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:23 Changed 6 years ago by dnarvaez

  • Milestone changed from 1.0 to Unspecified

comment:24 Changed 6 years ago by dnarvaez

  • Bug Status changed from Assigned to Unconfirmed

comment:25 Changed 6 years ago by dnarvaez

  • Bug Status changed from Unconfirmed to New
  • Priority changed from Normal to Urgent

comment:26 Changed 6 years ago by dnarvaez

  • Milestone changed from Unspecified to 0.102

comment:27 Changed 5 years ago by manuq

  • Priority changed from Urgent to Normal
Note: See TracTickets for help on using tickets.