Opened 11 years ago

Closed 11 years ago

#3037 closed defect (fixed)

Distance fails to start measuring

Reported by: greenfeld Owned by: RafaelOrtiz
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Distance Version: 0.92.x
Severity: Major Keywords: 11.3.0
Cc: Distribution/OS: OLPC
Bug Status: Unconfirmed

Description (last modified by greenfeld)

Distance-23 fails to start measuring on OLPC 11.3.0 os2. (Version number was wrong initially.)

Both the starting computer and the one joining the shared session log the following exception:

Traceback (most recent call last):

File "/home/olpc/Activities/Distance.activity/activity.py", line 291, in _helper_thread

dt = arange.measure_dt_seq(self.main_socket, self.initiating, self._change_message)

File "/home/olpc/Activities/Distance.activity/arange.py", line 418, in measure_dt_seq

mls = compute_mls(R)

File "/home/olpc/Activities/Distance.activity/arange.py", line 84, in compute_mls

return LFSR(Rf, [i - 1 for i in taps[n]], 2n - 1)

NameError: global name 'Rf' is not defined

Attachments (1)

0001-removed-spam-introduced-by-Commit-efd02466335d8f8677.patch (2.4 KB) - added by walter 11 years ago.
patch to remove spurious 'f' characters scattered throughout the file

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by walter

patch to remove spurious 'f' characters scattered throughout the file

comment:1 Changed 11 years ago by walter

Rafael, you must have not applied the attached patch which cleans up errors introduced here:

http://git.sugarlabs.org/distance/distance/commit/efd02466335d8f8677d73b8e04bdeefb310aaa48

But upon closer examination, it seems you did apply the patch:

http://git.sugarlabs.org/distance/distance/commit/f53ad6ef6d23ed069def5c89955fe61069cbc4ff

I don't know how those typos are back in the code.

comment:2 Changed 11 years ago by RafaelOrtiz

Maybe greenfield is not trying with an updated repo ?

http://git.sugarlabs.org/distance/distance/blobs/master/arange.py

mainline shows the corrected version.

comment:3 Changed 11 years ago by greenfeld

If it is fixed in a new activity release please ask dsd or erikos to pull it.

At the moment we should just be pulling the latest from ASLO, and ASLO lists Distance-23 from May 2011 as the latest.

comment:4 Changed 11 years ago by greenfeld

  • Description modified (diff)

comment:5 Changed 11 years ago by greenfeld

Distance-23 as downloaded from ASLO right now does not appear to have this patch:

    return LFSR(Rf, [i - 1 for i in taps[n]], 2**n - 1)
    returnf (rec_process, f)
    rec_profcess.wait()

comment:6 Changed 11 years ago by RafaelOrtiz

Packaged in V24 of distance.

comment:7 Changed 11 years ago by RafaelOrtiz

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.