Opened 10 years ago

Closed 10 years ago

#2986 closed defect (fixed)

TurtleArt fails to launch due to keyboard shortcut workaround

Reported by: dsd Owned by: walter
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Turtleart Version: Unspecified
Severity: Unspecified Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

With the latest sugar-toolkit master and 0.92 that includes http://cgit.sugarlabs.org/sugar-toolkit/mainline.git/commit/?id=880e60bddaed0d5258afb4f53e135e55745245ac

TurtleArt fails to launch.

Gonzalo suggests the fix:

diff --git a/TurtleArtActivity.py b/TurtleArtActivity.py
index 69bb506..ba0e60c 100644
--- a/TurtleArtActivity.py
+++ b/TurtleArtActivity.py
@@ -589,13 +589,7 @@ class TurtleArtActivity(activity.Activity):
         self._toolbox.show()
         # Setup palette toolbar only *after* initializing the plugins
 
-        if self.has_toolbarbox:
-            # Hack as a workaround for #2050
-            edit_toolbar_button.set_expanded(True)
-            edit_toolbar_button.set_expanded(False)
-
-            self._palette_toolbar_button.set_expanded(True)
-        else:
+        if not self.has_toolbarbox:
             self._toolbox.set_current_toolbar(1)
 
     def _setup_palette_toolbar(self):

Change History (5)

comment:1 Changed 10 years ago by walter

So Gonzalo's accelerator key patch has landed? And it breaks the activities that had work-arounds? Strange, but given the situation, I am happy to provide a patch as per his suggestion. I'll have to fix a few other activities that use this workaround as well.

Question: What version of TA do you want patched? I'd prefer to give you something based on v110, which has some bug-fixes. See http://git.sugarlabs.org/turtleart/mainline/blobs/master/NEWS

comment:2 Changed 10 years ago by dsd

Yes, it was landed after a couple of mail threads and several days of sitting quietly for review on the mailing list. I don't think he was aware that activities had attempted a workaround, and certainly wasn't aware that it would break them. We only saw the breakage after the fact. Sorry about that.

From the OLPC standpoint, just landing fixes in master branches and doing new activity releases in due course is good enough - no need for any specific special releases. We are not including the fix in 11.2.0.

comment:4 Changed 10 years ago by walter

Still to fix for the same issue:

Abacus
TurtleConfusiuon
TurtleArtMini
TurtleArtButia
Slideruler

comment:5 Changed 10 years ago by walter

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.