Clock activity does not initially center full time text

[greenfeld]

When the "Display time in full letters" button is enabled, the text that appears is not centered the first time it is displayed.

After a new minute passes then the text gets updated and centered.

Seen in OLPC 11.2.0 os17.

[manuq]

Confirmed with my XO. It seems that the text is not centered again when the string changes from the default "What time is it?" to the actual text with the time in letters in the _time_letters gtk label.

I tried calling _time_letters.queue_draw() and self.redraw_canvas() but wasn't succeed :(

The bug is not happening in my development machine running Sugar from sugar-jhbuild .

[garycmartin]

Replying to manuq:

Confirmed with my XO. It seems that the text is not centered again when the string changes from the default "What time is it?" to the actual text with the time in letters in the _time_letters gtk label.

I tried calling _time_letters.queue_draw() and self.redraw_canvas() but wasn't succeed :(

The bug is not happening in my development machine running Sugar from sugar-jhbuild .

Yea, it's something related to the new Fedora, didn't happen in previous olpc official releases. I tried to work on it but it looks like a gtk idle race thing as the original Clock developer decided to do the text rendering in a background thread (have been considering refactoring this out). When first enabled the text gets incorrectly centred based on the 'what time is it?' string before the real time text is generated. It's centered correctly on the next redraw (each min, or if you show the date text).

[manuq]

This image shows the problem:

​http://dev.laptop.org/~manuq/clock_text_bug.png

I think a refactor that removes the two threads will work.

[garycmartin]

Fixed in git by removing idle updates, should be in release Clock-7.

[manuq]

Very good Gary, the bug is gone. Tested in XO 1.75 and XO 1.5.