Opened 12 years ago

Closed 10 years ago

#2817 closed defect (obsolete)

combobox.py should catch exception when icon fails to load

Reported by: walter Owned by: erikos
Priority: Normal Milestone: Unspecified
Component: Sugar Version: Git as of bugdate
Severity: Unspecified Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

I thought I had reported this before and I had fixed it in my local copy, but I cannot find the ticket.

The Balloon activity has a broken icon svg file which is causing the append_item method in combobox.py to throw an exception and prevent Sugar from launching properly.

pseudo patch:
lines 116-117

  • pixbuf = gtk.gdk.pixbuf_new_from_file_at_size(
  • file_name, width, height)

+ try:
+ pixbuf = gtk.gdk.pixbuf_new_from_file_at_size(
+ file_name, width, height)
+ except:
+ pixbuf = None

This happened when I installed the latest update to Sugar which apparently overwrote the patch I had applied earlier.

Change History (3)

comment:1 Changed 10 years ago by dnarvaez

  • Component changed from sugar-toolkit to Sugar

comment:2 Changed 10 years ago by dnarvaez

  • Bug Status changed from Unconfirmed to New
  • Priority changed from Unspecified by Maintainer to Normal

Please catch the specific exception though.

comment:3 Changed 10 years ago by walter

  • Resolution set to obsolete
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.