Opened 9 years ago

Closed 8 years ago

#2756 closed defect (fixed)

"Become Root" button in Terminal Activity kills anything running in current Terminal session

Reported by: greenfeld Owned by: sayamindu
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Terminal Version: 0.92.x
Severity: Minor Keywords:
Cc: Distribution/OS: OLPC
Bug Status: Unconfirmed

Description

The "Become Root" button in the Terminal Activity kills anything running in the currently active Terminal session window.

I'm not so certain if this is a good idea or not. Since all it does is run "su -", why can't we let people run "su" manually?

A side effect is that if you exit the root shell prompt, the Terminal window closes. This is somewhat unexpected if you were trying to get back to the normal user of the terminal.

Reproduction:

  1. Run something which runs until exited like "top", etc. in a Terminal session.
  2. Press the "Become Root" button. Whatever was previously running from Step 1 has been killed off, and you will have a Bash root shell prompt {or hopefully asked for the password to one if so configured for your system}.

Seen with Terminal-31 in OLPC OS 11.2.0 os14.

Change History (3)

comment:2 Changed 9 years ago by greenfeld

Also of note: If the system needs to asks for a password, receives an invalid one, or otherwise is denied su rights, the terminal session then ends. If there was only one session open, this also forces the activity to exit.

This might be a good security deterrent, but could be very confusing for users.

comment:3 Changed 8 years ago by manuq

  • Resolution set to fixed
  • Status changed from new to closed

Become root functionality was removed in commit e1c0a89a947638fe2d31427b88501d1878194350 .

Note: See TracTickets for help on using tickets.