Opened 10 years ago

Closed 8 years ago

#2708 closed enhancement (fixed)

Paint should save control settings in its Journal entry

Reported by: greenfeld Owned by: godiard
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Paint Version:
Severity: Unspecified Keywords:
Cc: humitos Distribution/OS: OLPC
Bug Status: Unconfirmed

Description

I started work on a pretty painting with different colors and custom sizes for shapes in Paint-31. I then saved it to a Journal entry, and reopened it later to continue working.

The picture was there, but all my custom color, pixel, and fill settings were lost.

If possible we should save these. If someone screws these up too badly we should suggest/support importing the picture from the old instance of Paint into a new instance of Paint without resetting the controls.

Attachments (1)

save-restore-brush-properties.patch (16.0 KB) - added by humitos 8 years ago.
A very old patch that I was working on 10 months ago. Maybe it is useful to take some ideas or chunks of code

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by humitos

I'm going to start working on this ticket.

comment:2 Changed 9 years ago by humitos

I could save the state using write_file and load it using read_file without any problem. I'm restoring the last tool used by the user but I can't restore the colors: "fill color" and "stroke color" yet.

I'm using simplejson to store the data as string into self.metadata['state'].

I didn't find the way to let the GUI know that should use another color instead the default one. With "GUI" I refer to Area class.

comment:3 Changed 9 years ago by godiard

  • Keywords 11.3.0 added

comment:4 Changed 8 years ago by godiard

  • Milestone changed from Unspecified by Release Team to 1.0

comment:5 follow-ups: Changed 8 years ago by manuq

  • Cc humitos added

Humitos, do you still have your patch around? Gonzalo, any chance we can see at least the part that works landing?

comment:6 in reply to: ↑ 5 Changed 8 years ago by godiard

  • Keywords 11.3.0 removed
  • Version 0.92.x deleted

Replying to manuq:

Gonzalo, any chance we can see at least the part that works landing?

Yes :)

Changed 8 years ago by humitos

A very old patch that I was working on 10 months ago. Maybe it is useful to take some ideas or chunks of code

comment:7 in reply to: ↑ 5 Changed 8 years ago by humitos

Replying to manuq:

Humitos, do you still have your patch around?

I've just attached the patch to this ticket. I'm not sure if it will be useful, but maybe we can take some chunks of code or some ideas.

comment:8 Changed 8 years ago by dnarvaez

  • Milestone 1.0 deleted

Milestone 1.0 deleted

comment:9 Changed 8 years ago by godiard

  • Milestone set to Unspecified
  • Resolution set to fixed
  • Status changed from new to closed

Implemented on 181c0a8dfc5fd434a978498840586e3d2b3637ba

Note: See TracTickets for help on using tickets.