Opened 10 years ago

Closed 9 years ago

Last modified 8 years ago

#2593 closed defect (wontfix)

[dx2] Browse opens file chooser instead of journal entry selector

Reported by: m_anish Owned by: lucian
Priority: Urgent Milestone:
Component: Browse Version: Unspecified
Severity: Minor Keywords: dx2
Cc: dirakx, alsroot, lucian Distribution/OS: Dextrose
Bug Status: New

Description (last modified by m_anish)

Testcase

  1. Open Browse
  2. Log into GMail
  3. Compose a new message
  4. Try to add an attachment
  5. Instead of Journal entry selector, browse opens the file chooser dialog.

This issue exists on Browse 115/116 running on Dextrose-2, but doesn't seem to be present on jhbuild.

Attachments (2)

org.laptop.WebActivity-1.log (61.7 KB) - added by lucian 10 years ago.
Log of Browse running while this bug is reproduced.
org.laptop.WebActivity-2.log (32.1 KB) - added by lucian 10 years ago.
Log of a regular run of Browse

Download all attachments as: .zip

Change History (25)

comment:1 Changed 10 years ago by m_anish

  • Priority changed from Urgent to Immediate
  • Severity changed from Major to Blocker

comment:2 Changed 10 years ago by alsroot

  • Cc alsroot added
  • Priority changed from Immediate to Urgent
  • Severity changed from Blocker to Major

That issue is absent in v119 on dx-2

comment:3 follow-up: Changed 10 years ago by lucian

Could you please upload a log of 115/116 running on dx-2? If it's fixed in 119, I'd like to know why.

comment:4 in reply to: ↑ 3 Changed 10 years ago by m_anish

  • Description modified (diff)
  • Severity changed from Major to Minor

Replying to lucian:

Could you please upload a log of 115/116 running on dx-2? If it's fixed in 119, I'd like to know why.

Update (Test results Browse-119 on a XO-1; tests performed in the order as below):

(1) Objectchooser works correctly on wiki.sl.o
(2) Objectchooser works correctly on gmail.com | Basic HTML view
(3) Objectchooser does NOT work correctly on gmail.com | Standard view -> Pops up standard gnome filepicker instead of journal entry selector
(4) Doing (1) or (2) now popup the standard gnome file picker

I think I got a error/warning from sugar.graphics.objectchooser. Will search and paste log.

Since this exists in only some cases (as opposed to occurring everytime, I'm reducing severity to Minor)

comment:5 Changed 10 years ago by lucian

I've managed to reproduce this bug.

I don't really have an idea what's going on, there doesn't seem to be anything relevant in the logs. It may be an obscure mozilla/xpcom bug.

comment:6 follow-up: Changed 10 years ago by lucian

I still can't figure out why this happens, but I have found an anomaly with Gmail's markup

<input id=":jg" type="file" name="f_gk5yiy530" class="LIODqc" size="50" tabindex="2" "="">

It sometimes appears as

<input id=":jg" type="file" name="f_gk5yiy530" class="LIODqc" size="50" tabindex="2" ">

in a file inspector.

Furthermore, putting this <input in a separate file doesn't reproduce the issue. This leads me to believe it has something to do with how Gmail manipulates the DOM in gecko/xulrunner.

Obviously Browse/xulrunner shouldn't choke on this, but Gmail should have the right markup anyway. I've reported the bug with Google.

comment:7 in reply to: ↑ 6 Changed 10 years ago by lucian

Replying to lucian:

in a file inspector.

I meant in a DOM inspector (Webkits/Firebug).

Changed 10 years ago by lucian

Log of Browse running while this bug is reproduced.

Changed 10 years ago by lucian

Log of a regular run of Browse

comment:8 Changed 10 years ago by RafaelOrtiz

  • Resolution set to notsugar
  • Status changed from new to closed

Marking it as non-sugar, would be nice to have a link to the upstream bug.

comment:9 follow-up: Changed 10 years ago by lucian

I am not yet certain this is an upstream (i.e. mozilla/xulrunner/xpcom) bug.

About the Gmail bug reports, they're private. I can't get a link to it.

comment:10 in reply to: ↑ 9 ; follow-up: Changed 10 years ago by m_anish

Replying to lucian:

I am not yet certain this is an upstream (i.e. mozilla/xulrunner/xpcom) bug.

About the Gmail bug reports, they're private. I can't get a link to it.

For the time being, would including older (or newer) version of xulrunner that works well make sense?

For instance, I don't see the bug with up to date sugar-jhbuild running on a f13 machine.

comment:11 in reply to: ↑ 10 ; follow-up: Changed 10 years ago by lucian

Replying to m_anish:

Replying to lucian:

I am not yet certain this is an upstream (i.e. mozilla/xulrunner/xpcom) bug.

About the Gmail bug reports, they're private. I can't get a link to it.

For the time being, would including older (or newer) version of xulrunner that works well make sense?

For instance, I don't see the bug with up to date sugar-jhbuild running on a f13 machine.

If it doesn't happen on a newer xulrunner, that increases my confidence that the bug is there, not in Browse.

I don't really know if newer xulrunner is a feasible solution in the field.

comment:12 in reply to: ↑ 11 Changed 10 years ago by RafaelOrtiz

Replying to lucian:

Replying to m_anish:

Replying to lucian:

I am not yet certain this is an upstream (i.e. mozilla/xulrunner/xpcom) bug.

About the Gmail bug reports, they're private. I can't get a link to it.

For the time being, would including older (or newer) version of xulrunner that works well make sense?

I'd say go for it, if we can fix the issue with a new xulrunner, might be work to try..we need to know wich version fits best.

For instance, I don't see the bug with up to date sugar-jhbuild running on a f13 machine.

If it doesn't happen on a newer xulrunner, that increases my confidence that the bug is there, not in Browse.

I don't really know if newer xulrunner is a feasible solution in the field.

comment:13 Changed 10 years ago by m_anish

  • Resolution notsugar deleted
  • Status changed from closed to reopened

This issue does not exist on Browse running on the latest f14-11.x development builds. Might be worth exploring what versions of relevant packages are being used there and see if we can do something about it in f11.

Reopening.

comment:14 Changed 10 years ago by RafaelOrtiz

  • Cc lucian added

comment:15 Changed 10 years ago by RafaelOrtiz

I've investigated this, as anish said is not happening in F14

relevant packages versions.

xulrunner-1.9.2.10-1.fc14.1.i686
hulahop-0.7.1-3.fc14.i686

comment:16 Changed 10 years ago by RafaelOrtiz

tested in sweets stable=sugar0.88 and testing=sugar0.92, not happening.

comment:17 Changed 10 years ago by RafaelOrtiz

  • Keywords dx3 added
  • Milestone changed from Unspecified by Release Team to not applicable

comment:18 Changed 10 years ago by RafaelOrtiz

should be fixed on dx3 with the new version of xulrunner.

comment:19 Changed 9 years ago by m_anish

  • Keywords dx3 removed

[Keywords -= dx3] This doesn't happen on dx3.

comment:20 Changed 9 years ago by manuq

For the relevant ticket for current Browse featuring WebKit, see #3411 . Shall we close this one as obsolete?

comment:21 Changed 9 years ago by m_anish

+1 to closing this from my side (wontfix)

comment:22 Changed 9 years ago by manuq

  • Resolution set to wontfix
  • Status changed from reopened to closed

comment:23 Changed 8 years ago by dnarvaez

  • Milestone not applicable deleted

Milestone not applicable deleted

Note: See TracTickets for help on using tickets.