Opened 9 years ago

Closed 5 years ago

#2572 closed enhancement (obsolete)

sharing logic is broken

Reported by: rgs Owned by: rgs
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Turtleart Version: Unspecified
Severity: Unspecified Keywords: turtle art clean up
Cc: walter Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

In my latest set of patches [1] I broke the sharing logic causing events to be sent over even when we are not sharing. The sharing() method in TurtleArt/tawindow.py needs to be reworked to adapt to our current scenario of common sharing logic between our Sugar and Gnome code paths.

This bug also triggered another discussion, the logic to dispatch commands and then send the event across the network is redundant and confusing. One of the key points of confusion is the fact that each method in tacanvas needs a share parameter to know if the command being ran is local or is being executed on behalf of some other turtle in the network.

Upon discussion on #sugar an idea came up to simplify this logic and centralize various actions related to command execution.

We could have a queue where all commands, local and remote, would be saved to and then at some later point a command scheduler would be invoke to:

1) draw the command
2) notify turtles over the network of the executed command
3) perform logging
4) highlight the executed block
5) do some user configured action upon each command execution

[1] http://git.collabora.co.uk/?p=user/rgs/turtleart/.git;a=summary

Change History (1)

comment:1 Changed 5 years ago by godiard

  • Resolution set to obsolete
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.