Opened 12 years ago

Closed 12 years ago

#2446 closed defect (fixed)

Journal toolbar search field should expand to consume available space

Reported by: garycmartin Owned by:
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: untriaged Version: Unspecified
Severity: Minor Keywords: olpc-0.90 r+
Cc: erikos Distribution/OS: Unspecified
Bug Status: Resolved

Description

This looks like a design regression from previous Sugar releases that I think slipped in with the addition of the new sort options icon. Attached a screen shot taken on an XO-1 running the F14 test 0.90 build.

Attachments (3)

Journal toolbar.png​ (20.1 KB) - added by garycmartin 12 years ago.
Journal_toolbar_after_removing_expanding_separator.png​ (81.0 KB) - added by garycmartin 12 years ago.
0001-Remove-separator-so-Journal-search-field-fills-avail.patch​ (1.5 KB) - added by garycmartin 12 years ago.
Patch removing toolbar separator and the _add_separator method.

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by garycmartin

comment:1 Changed 12 years ago by garycmartin

Looking at /usr/lib/python2.7/site-packages/jarbe/journal/journaltoolbox.py at about line number 112, there is a:

self._add_separator(expand=True)

Remove this, and the search field is correctly expanding to fill the available space again. See attached screen shot.

Changed 12 years ago by garycmartin

comment:2 Changed 12 years ago by garycmartin

  • Cc erikos added
  • Keywords r? added

Just a ping to see if this can land at all.

comment:3 follow-up: Changed 12 years ago by erikos

  • Keywords r+ added; r? removed

Looks good. As the _add_separator method is not used anymore we can remove it. r+ with that change

Changed 12 years ago by garycmartin

Patch removing toolbar separator and the _add_separator method.

comment:4 in reply to: ↑ 3 Changed 12 years ago by garycmartin

Replying to erikos:

Looks good. As the _add_separator method is not used anymore we can remove it. r+ with that change

Fab :) git format-patch attached with both the separator line, and the _add_separator method removed.

comment:5 Changed 12 years ago by erikos

  • Bug Status changed from Unconfirmed to Resolved
  • Resolution set to fixed
  • Status changed from new to closed

master: ​http://git.sugarlabs.org/sugar/mainline/commit/4a63bc3121d6084804ef8445d0cdc50160810b65

0.90: ​http://git.sugarlabs.org/sugar/mainline/commit/76a582a46f38bc196570078e1a22794da560a303

Thanks Gary!

Note: See TracTickets for help on using tickets.