Multiple turtles inconsistent behaviour with clean

[tonyforster]

Clean erases multiple turtles but they return if you rename the activity, go to journal and back or quit.
OS17, 0.90 XO1 V99

[walter]

Clean doesn't erase the turtles... it just brings them all back to 'home'. You can erase turtles by dragging them on to the palette.

Should clean erase the turtles?

[walter]

Could you please do your further testing with the new release candidate, v100, available here:

​http://wiki.sugarlabs.org/go/File:TurtleArt-100.xo

[tonyforster]

Replying to walter:

Clean doesn't erase the turtles... it just brings them all back to 'home'. You can erase turtles by dragging them on to the palette.

Should clean erase the turtles?

Thanks. V99 clean also hides the turtles. The user would expect them to stay hidden. My preference is that clean erase (or hide) them but what is important is that whatever clean does should be consistent.

Will try on V100.

[tonyforster]

The attached screenshot illustrates the problem, the oscilloscope has been used on 3 machines and the ta file has picked up 3 turtles, 2 unknown to the user

["turtle", "Tony"], 0, 0, 0, 0, 50, 5], [-1, ["turtle", "Tony1.5"], -316, 113, 0, 0, 50, 5], [-1, ["turtle", "Yertle"], 380, 113, 0, 0, 50, 5]]

As the screenshot shows, alt tab unhides the 2 turtles

[walter]

Maybe rather than saving the default turtle by the user's nick, I should just save it as 'Yertle', which is the default; then I can test for that case and not inadvertently load or save extra turtles.

#2687 includes a patch to prevent shared turtles from getting saved with a project.

[walter]

In theory this patch (with the wrong commit message) will fix the problem above (but not retroactively).

​http://git.sugarlabs.org/turtleart/mainline/commit/b658b9f0c3856fe496c8bc9707aaab512b3ae829