Opened 10 years ago

Closed 10 years ago

Last modified 7 years ago

#2175 closed defect (fixed)

ActivityBundle._parse_info() mentions recently removed 'class' key

Reported by: sascha_silbe Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Major Keywords:
Cc: Distribution/OS:
Bug Status: New

Description

If an activity bundle uses the obsolete class key instead of exec, sugar.bundle.activitybundle.ActivityBundle._parse_info() raises a sugar.bundle.bundle.MalformedBundleException that tells the user to set exec or class. This is going to be rather confusing to activity developers.

*** Installing pippy *** [17/26]
python setup.py install --prefix /home/sascha.silbe/sugar-jhbuild/install
Traceback (most recent call last):
  File "setup.py", line 21, in <module>
    bundlebuilder.start()
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/activity/bundlebuilder.py", line 415, in start
    config = Config()
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/activity/bundlebuilder.py", line 80, in __init__
    self.update()
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/activity/bundlebuilder.py", line 83, in update
    self.bundle = bundle = ActivityBundle(self.source_dir)
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/bundle/activitybundle.py", line 67, in __init__
    self._parse_info(info_file)
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/bundle/activitybundle.py", line 168, in _parse_info
    self._path)
sugar.bundle.bundle.MalformedBundleException: Activity bundle /home/sascha.silbe/sugar-jhbuild/source/pippy must specify either class or exec
*** Error during phase install of pippy: ########## Error running python setup.py install --prefix /home/sascha.silbe/sugar-jhbuild/install *** [17/26]

Change History (3)

comment:1 Changed 10 years ago by erikos

  • Resolution set to fixed
  • Status changed from new to closed

Sascha, sorry for the noise.

I brought them back, as many activities seems to still use those fields: http://git.sugarlabs.org/projects/sugar-toolkit/repos/mainline/commits/acd8095a29f2f922acce3e907fb71a6019eff113

For now we have a warning to change the occurrences: http://git.sugarlabs.org/projects/sugar-toolkit/repos/mainline/commits/981707c112aea3d12c4b0140e6e4510931c177f6

comment:2 Changed 7 years ago by dnarvaez

  • Component changed from sugar-toolkit to Sugar

comment:3 Changed 7 years ago by dnarvaez

  • Milestone 0.90 deleted

Milestone 0.90 deleted

Note: See TracTickets for help on using tickets.