Cannot delete stalled download from journal

[tonyforster]

In OS140py, also seen in an earlier py OS

1273025700.458246 ERROR root: Cannot update the palette position.
Exception AttributeError: "'ActivityBundle' object has no attribute '_zip_file'" in <bound method ActivityBundle.del of <sugar.bundle.activitybundle.ActivityBundle object at 0x8e032ac>> ignored
Traceback (most recent call last):

File "/usr/lib/python2.6/site-packages/jarabe/journal/palettes.py", line 139, in erase_activate_cb

bundle = misc.get_bundle(self._metadata)

File "/usr/lib/python2.6/site-packages/jarabe/journal/misc.py", line 102, in get_bundle

return ActivityBundle(file_path)

File "/usr/lib/python2.6/site-packages/sugar/bundle/activitybundle.py", line 48, in init

Bundle.init(self, path)

File "/usr/lib/python2.6/site-packages/sugar/bundle/bundle.py", line 68, in init

self._zip_file = zipfile.ZipFile(self._path)

File "/usr/lib/python2.6/zipfile.py", line 698, in init

self._GetContents()

File "/usr/lib/python2.6/zipfile.py", line 718, in _GetContents

self._RealGetContents()

File "/usr/lib/python2.6/zipfile.py", line 728, in _RealGetContents

endrec = _EndRecData(fp)

File "/usr/lib/python2.6/zipfile.py", line 189, in _EndRecData

fpin.seek(-sizeEndCentDir, 2)

IOError: [Errno 22] Invalid argument
1273025708.704679 WARNING root: No gtk.AccelGroup in the top level window.
1273025708.719241 WARNING root: No gtk.AccelGroup in the top level window.
1273025708.723876 WARNING root: No gtk.AccelGroup in the top level window.
1273025708.759601 WARNING root: No gtk.AccelGroup in the top level window.
1273025708.774534 WARNING root: No gtk.AccelGroup in the top level window.
1273025710.794003 WARNING root: No gtk.AccelGroup in the top level window.

[tonyforster]

screenshot showing multiple stalled downloads

[tonyforster]

see also 1988

[erikos]

Can we get a description how to reproduce this bug? I can reproduce 1988, but not this one. The patch does look good otherwise, but I would like to be able to test it.

@Tony: What Sugar version does the image you posted have?

[tonyforster]

version is OS140py

I don't know why the download stalled in the first place but I can replicate by commencing a download of turtleart mini from activities.sugarlabs.org and then unplugging the modem. The partially downloaded bundle cannot be deleted from the journal. (and it doesnt resume when connectivity is restored)

[bernie]

This is a dupe of #1876.

[erikos]

Looks good, please go ahead.

[alsroot]

​http://git.sugarlabs.org/projects/sugar-toolkit/repos/mainline/commits/883fefe78295fa8ca427c18a8b372c5d81b99b1e

[erikos]

Patch for 0.84