bundlebuilder should not use locale name

[walter]

I have an activity that has a different name in the locale/en.po file than in activity.info. bundlebuilder uses the locale name to create the .pot file, the .xo and .tar files whereas I think it should always use the name from the activity.info file. The attached patch uses the name from activity.info in bundlebuilder while preserving the locale/ name for user-facing strings. I opted to add a new method, get_bundle_name so as to preserve any calls to get_name that expect the localized name.

[walter]

patch to differentiate locale name from bundle name

[walter]

I realized I had accidentally assigned the wrong keyword for requesting review.

[erikos]

The patch does look good to me, thanks a lot for that. How critical is it to land that one? Did it cause problems in the field or is it more of an edge case? Just to know whether we land it in 0.88.x (and maybe even backport to 0.84) or move it to 0.90.

Testing instructions to verify the fix would be great, too.

[walter]

It has caused problems in the field in that many people were confused when trying to install both Turtle Art and Turtle Blocks. They'll even be more confused when we release Turtle Art Arduino and Turtle Art with Sensors.

I would vote for 0.88.x and backporting to the 0.84 releases that are going to be in the field.

[erikos]

Walter, thanks for the feedback. Please push to 0.88.

[erikos]

Pushed as: ​http://git.sugarlabs.org/projects/sugar-toolkit/repos/mainline/commits/3aa099509676d795873668948f3b4646aab9419a

Leaving open for 0.84.

[erikos]

Opened ​http://dev.laptop.org/ticket/10313 to track inclusion in 0.84.

[godiard]

Milestone 0.84 deleted