Opened 10 years ago

Closed 10 years ago

Last modified 7 years ago

#1968 closed defect (fixed)

bundlebuilder should not use locale name

Reported by: walter Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Critical Keywords: r+ olpc-0.84
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

I have an activity that has a different name in the locale/en.po file than in activity.info. bundlebuilder uses the locale name to create the .pot file, the .xo and .tar files whereas I think it should always use the name from the activity.info file. The attached patch uses the name from activity.info in bundlebuilder while preserving the locale/ name for user-facing strings. I opted to add a new method, get_bundle_name so as to preserve any calls to get_name that expect the localized name.

Attachments (1)

bundle.patch (2.1 KB) - added by walter 10 years ago.
patch to differentiate locale name from bundle name

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by walter

patch to differentiate locale name from bundle name

comment:1 Changed 10 years ago by walter

  • Keywords r? added; r! removed

I realized I had accidentally assigned the wrong keyword for requesting review.

comment:2 Changed 10 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Keywords r+ added; r? removed

The patch does look good to me, thanks a lot for that. How critical is it to land that one? Did it cause problems in the field or is it more of an edge case? Just to know whether we land it in 0.88.x (and maybe even backport to 0.84) or move it to 0.90.

Testing instructions to verify the fix would be great, too.

comment:3 Changed 10 years ago by walter

It has caused problems in the field in that many people were confused when trying to install both Turtle Art and Turtle Blocks. They'll even be more confused when we release Turtle Art Arduino and Turtle Art with Sensors.

I would vote for 0.88.x and backporting to the 0.84 releases that are going to be in the field.

comment:4 Changed 10 years ago by erikos

Walter, thanks for the feedback. Please push to 0.88.

comment:5 Changed 10 years ago by erikos

  • Keywords olpc-0.84 added
  • Milestone changed from Unspecified by Release Team to 0.84

comment:6 Changed 10 years ago by erikos

  • Resolution set to fixed
  • Status changed from new to closed

Opened http://dev.laptop.org/ticket/10313 to track inclusion in 0.84.

comment:7 Changed 7 years ago by godiard

  • Milestone 0.84 deleted

Milestone 0.84 deleted

comment:8 Changed 7 years ago by dnarvaez

  • Component changed from sugar-toolkit to Sugar
Note: See TracTickets for help on using tickets.