Opened 11 years ago

Closed 10 years ago

Last modified 7 years ago

#1862 closed defect (fixed)

Unneeded debug logs

Reported by: erikos Owned by: alsroot
Priority: Unspecified by Maintainer Milestone:
Component: journal Version: Unspecified
Severity: Minor Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

src/jarabe/journal/model.py:188:            logging.debug('cache hit and no need to grow the cache')
src/jarabe/journal/model.py:111:        logging.debug('ResultSet.read position: %r', self._position)

I think we can remove those debug logs. They clutter the logs and don't bring as much value, imho.

Attachments (1)

0001-Remove-unneeded-journal-debug-logs-1862.patch (1.1 KB) - added by erikos 10 years ago.
Patch against master

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by tomeu

  • Component changed from sugar to journal
  • Owner changed from tomeu to alsroot

missing patch?

comment:2 follow-up: Changed 10 years ago by erikos

  • Keywords r! added; r? removed

Aleksey can you comment if you agree on my assumption that those logs are not necessary? If yes I will do a patch of course.


comment:3 in reply to: ↑ 2 Changed 10 years ago by alsroot

Replying to erikos:

Aleksey can you comment if you agree on my assumption that those logs are not necessary? If yes I will do a patch of course.

Agree, these messages are pretty annoying. If there is need to have it in released sugar, we can add special debug flag.

Changed 10 years ago by erikos

Patch against master

comment:4 Changed 10 years ago by erikos

  • Keywords r? added; r! removed

comment:5 Changed 10 years ago by alsroot

  • Keywords r+ added; r? removed

comment:6 Changed 10 years ago by erikos

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed 7 years ago by dnarvaez

  • Milestone 0.90 deleted

Milestone 0.90 deleted

Note: See TracTickets for help on using tickets.