Opened 11 years ago

Closed 11 years ago

Last modified 7 years ago

#1764 closed defect (fixed)

Can not star (favi icon) an entry in the Journal (0.84)

Reported by: erikos Owned by: sayamindu
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: 0.84.x
Severity: Critical Keywords: r+
Cc: dsd Distribution/OS: Unspecified
Bug Status: New

Description

diff --git a/src/jarabe/journal/collapsedentry.py b/src/jarabe/journal/collapsedentry.py
index c3c45a3..71c2a5a 100644
--- a/src/jarabe/journal/collapsedentry.py
+++ b/src/jarabe/journal/collapsedentry.py
@@ -211,9 +211,9 @@ class BaseCollapsedEntry(hippo.CanvasBox):
 
     def __keep_icon_button_release_event_cb(self, button, event):
         logging.debug('__keep_icon_button_release_event_cb')
+        metadata = model.get(self._metadata['uid'])
         if not model.is_editable(metadata):
             return
-        metadata = model.get(self._metadata['uid'])
         if self.get_keep():
             metadata['keep'] = 0
         else:

This is nbot true in recent version of Sugar but in 0.84.

Change History (3)

comment:1 Changed 11 years ago by erikos

  • Summary changed from Can not start an entry in the Journal (0.84) to Can not star (favi icon) an entry in the Journal (0.84)

comment:2 Changed 11 years ago by sayamindu

  • Keywords r+ added; r? removed
  • Resolution set to fixed
  • Status changed from new to closed

Thanks. Committed.

comment:3 Changed 7 years ago by godiard

  • Milestone 0.84 deleted

Milestone 0.84 deleted

Note: See TracTickets for help on using tickets.