3G Support: show connection errors

[Dcastelo]

This patch improves the feature 3G Support (added in 0.88).
Includes:
Show the connection errors
Apply Eben's Mockup: ​http://wiki.sugarlabs.org/go/File:3G_device.png

[Dcastelo]

This ticket applies over ​http://bugs.sugarlabs.org/ticket/1738

[Dcastelo]

I can't atach the patch:
Submission rejected as potential spam (Akismet says content is spam, Content contained these blacklisted patterns: 'LE*')

[sascha_silbe]

I've configured Trac not to look at attachment content now. Please try attaching it again.

[Dcastelo]

Ebens Mockup for GSM Connection Palett. Improve feature to show connection errors

[erikos]

Hi Daniel,

with landing #1768, your patch needs to be re-spinned to head :/

Did you run pylint and pep8 on the files affected by your patch. I think I saw a wrong indentation... For the NM_ERRORS, I guess I would only add the ones that we actually use. self.conn_info_box, please no abbreviation here.

Regards,

Simon

[Dcastelo]

Minor changes: Change "up-down" icons

[Dcastelo]

Minor changes: Change "connect" and "cancel" icons

[erikos]

I would suggest it as a bug fix update as Daniel stated that the deployments Uruguay and Paraguay woul dbe interested in getting this in.

[tomeu]

The patch needs to address some comments made in ​http://lists.sugarlabs.org/archive/sugar-devel/2010-May/023972.html

[Dcastelo]

Improves based on comments made by James Cameron (​http://lists.sugarlabs.org/archive/sugar-devel/2010-May/023972.html)

Details about the corrections in ​http://lists.sugarlabs.org/archive/sugar-devel/2010-May/024182.html

Patch: 0001-Showing-Errors-Pallete-Mockup-V5.patch

[Dcastelo]

Improvements based on comments made by James Cameron

[tch]

Just tested "0001-Showing-Errors-Pallete-Mockup-V5.patch" and it works great :) Also looks very nice!

[tomeu]

Simon, thanks for correcting the flag.

I think this patch is pretty much ready for merging, with these comments:

• please run pylint
• initializing NM_DEVICE_STATE_REASON_DESCRIPTION like in the patch means calling gettext several times at startup. Better do it lazily as needed.

+ if (connection_time is not None):
+ self.props.secondary_text = _('Connected for ' + \
+ connection_time.strftime('%H:%M:%S'))
+ else:
+ self.props.secondary_text = _('Connected for ' \
+ + '00:00:00')

This won't get you the strings translated, try instead:

_('Connected for %s') % connection_time.strftime('%H:%M:%S')

A TRANS comment may be needed for translators to know better what they have to translate.

Remember that today is UI freeze.

[erikos]

device attached

[erikos]

Error message with current code

[erikos]

Proposal

[garycmartin]

Mock-up suggestion

[erikos]

New patch that does address Tomeu's comments and a slightly modified design (after discussion with Gary)

[erikos]

Connect

[erikos]

Error: could not connect / false config

[erikos]

No connection set in the CP

[erikos]

​http://bugs.sugarlabs.org/attachment/ticket/1759/gsm_error_1.png

​http://bugs.sugarlabs.org/attachment/ticket/1759/gsm_error_2.png

Gary, the code had two parts for the alert (I did not see that yesterday): So we have an error message and a suggestion what changes could help. I made the title (Error) bold and do place the suggestion below it. What do you think - is that visually acceptable? The rest I changed like we discussed yesterday.

[erikos]

Got a 'r+' from Tomeu and a 'fab' from Gary via irc.

​http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/bcebef6fb02f20f1ac456cbc43c7ab3062f2d962

[erikos]

Thanks Daniel for working on this! I thought I would champion it quickly so it does not miss another boat...

[Dcastelo]

Thanks you for finish this issue !

[dnarvaez]

Milestone 0.88.x deleted