Opened 13 years ago

Closed 13 years ago

Last modified 10 years ago

#1736 closed enhancement (fixed)

Disconnect icon in wifi palette

Reported by: erikos Owned by: tomeu
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Unspecified
Severity: Minor Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

This adds consistency to the palettes in the Neighborhood view. Patch attached.

For me it would be ok to slip it in 0.88, as it is such a minimal non-invasive change. Though, up to you Tomeu.

Attachments (1)

Disconnect_icon_in_wifi_palette.patch​ (1.1 KB) - added by erikos 13 years ago.
Patch for the Wireless device icon palette

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by erikos

Patch for the Wireless device icon palette

comment:1 follow-up: Changed 13 years ago by erikos

Actually, the icon does not need to be assigned to a private member.

comment:2 Changed 13 years ago by erikos

  • Milestone set to 0.90

comment:3 in reply to: ↑ 1 Changed 13 years ago by tomeu

  • Keywords r+ added; r? removed

Replying to erikos:

Actually, the icon does not need to be assigned to a private member.

Yup, better have it as a local variable.

comment:4 Changed 13 years ago by erikos

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for the review!

​http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/55f08d78c2a12a9a18e1e245fd0f0df8f76442b5

comment:5 Changed 10 years ago by dnarvaez

  • Milestone 0.90 deleted

Milestone 0.90 deleted

Note: See TracTickets for help on using tickets.