Opened 9 years ago

Closed 9 years ago

#1651 closed enhancement (fixed)

simplify jarabe.journal.model._Cache

Reported by: sascha_silbe Owned by: sascha_silbe
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: journal Version: Git as of bugdate
Severity: Unspecified Keywords: r+
Cc: tomeu, alsroot Distribution/OS: Unspecified
Bug Status: Assigned

Description

jarabe.journal.model._Cache can be simplified a great deal just by changing the way removes are done. This decreases memory usage (as we don't need to keep a dictionary that just duplicates the list) and also fixes a bug I encountered in my version support branch (but couldn't trigger on mainline).

I've kept the class to minimize the code changes, but I cannot see a reason why we'd need it - a simple list should do.

Attachments (1)

1651.patch (3.0 KB) - added by sascha_silbe 9 years ago.
simplify jarabe.journal.model._Cache

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by sascha_silbe

simplify jarabe.journal.model._Cache

comment:1 Changed 9 years ago by tomeu

  • Cc alsroot added
  • Component changed from sugar to journal

Aleksey is the Journal maintainer.

comment:2 follow-up: Changed 9 years ago by alsroot

  • Keywords r+ added; r? removed

comment:3 in reply to: ↑ 2 Changed 9 years ago by sascha_silbe

  • Resolution set to fixed
  • Status changed from new to closed

Pushed as ab68ecfbcd67, thanks!

Note: See TracTickets for help on using tickets.