#1548 closed defect (fixed)
unhelpful error message for unsupported codecs
Reported by: | sascha_silbe | Owned by: | humitos |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | |
Component: | Jukebox | Version: | Git as of bugdate |
Severity: | Unspecified | Keywords: | |
Cc: | godiard | Distribution/OS: | Unspecified |
Bug Status: | New |
Description
If a Journal entry can't be played due to a missing codec, the error message presented is not only hard to understand for children, but also doesn't mention which codec is missing:
Error: There is no codec present that can handle the stream's type. - gstplaybasebin.c(2327): prepare_output(): /GstPlayBin:player
Attachments (6)
Change History (22)
comment:1 Changed 14 years ago by RafaelOrtiz
- Milestone changed from Unspecified by Release Team to 0.88
comment:2 Changed 12 years ago by godiard
- Cc godiard added
- Keywords 11.3.0 added
- Milestone changed from 0.88 to 0.94
comment:3 Changed 11 years ago by godiard
- Keywords easy-hack added; 11.3.0 removed
comment:4 Changed 11 years ago by godiard
- Keywords 12.1.0 added
comment:5 Changed 11 years ago by godiard
- Owner changed from kushal to godiard
- Status changed from new to assigned
comment:6 Changed 11 years ago by erikos
- Keywords 12.1.0 removed
- Milestone changed from 0.94 to 0.98
Moving this one out.
comment:7 Changed 11 years ago by manuq
Also (but less important) would be good to style the message box.
comment:8 Changed 11 years ago by garycmartin
That is rather unhelpful & ugly! ;) Some suggestions: Centre the message, plenty of padding either side of the text, line wrap if necessary, remove the technical jargon/code, put an error badge icon above the text as per designs like the other user feedback in ticket #3714 [1]. If we can't easily get at the missing codec name, then a clear, friendly error message would be a good improvement over the current behaviour:
[1] http://bugs.sugarlabs.org/attachment/ticket/3714/Jukebox_playlist_informational_only.png
comment:9 Changed 11 years ago by humitos
- Owner changed from godiard to humitos
- Status changed from assigned to accepted
comment:10 Changed 11 years ago by humitos
- Keywords r? added
The message shown in the canvas was moved to an ErrorAlert, so I improved it a bit until we get the proper styling of the error in the canvas as Gary suggested (an screenshot of this is needed with the correct icons and texts)
Some comments:
- GStreamer does not inform us about what is the plug-in that is missing.
- There isn't an specific error code for missing plug-ins, so I had to check that in the error message.
I'm attaching a patch that does that and tries to make it a bit more friendly.
Changed 11 years ago by humitos
comment:11 Changed 11 years ago by humitos
In the future we can use this to install missing plugins:
comment:12 Changed 11 years ago by garycmartin
The dialogue msg text can drop the "Maybe", it should just read "The required plugin was not found for this type of file <mimetype>", otherwise this is looking good.
comment:13 follow-up: ↓ 14 Changed 11 years ago by humitos
Oh, sorry. Maybe I didn't explain well why we decided to use the word "Maybe" at the beginning.
GStreamer doesn't tell us about what is the specific error. It just says there was an ERROR but it could be for many reasons. So, as the most common error is a missing plugin, we use "Maybe" (because we are not sure :) )
comment:14 in reply to: ↑ 13 Changed 11 years ago by garycmartin
Replying to humitos:
Oh, sorry. Maybe I didn't explain well why we decided to use the word "Maybe" at the beginning.
GStreamer doesn't tell us about what is the specific error. It just says there was an ERROR but it could be for many reasons. So, as the most common error is a missing plugin, we use "Maybe" (because we are not sure :) )
Can the code check to see if <mimetype> is really missing? If this is too complicated, we should just go with a more generic version of the 'this file can't be played message'. Perhaps:
Error:
This "<mimetype>" file can not be played.
comment:15 Changed 11 years ago by godiard
- Keywords easy-hack r? removed
- Resolution set to fixed
- Status changed from accepted to closed
Pushed as 867c2d08570a5dc9a506071e84103612f4929320 with the message suggested by Gary
If a format file is not supported must show a nice and understandable message.