#151 closed defect (fixed)
browse displays a black square instead of preview
| Reported by: | tomeu | Owned by: | tomeu |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | hulahop | Version: | Git as of bugdate |
| Severity: | Minor | Keywords: | |
| Cc: | Distribution/OS: | Unspecified | |
| Bug Status: | Resolved |
Description
Change History (10)
comment:1 Changed 15 years ago by tomeu
comment:2 Changed 15 years ago by tomeu
- Owner changed from marcopg to tomeu
- Status changed from new to assigned
Submitted a patch upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=472051
comment:3 Changed 15 years ago by tomeu
Also, Benjamin's patch in http://bugzilla.gnome.org/show_bug.cgi?id=566535 fixes this without having to modify mozilla.
comment:4 Changed 15 years ago by gregdek
- Bug Status set to Unconfimed
- Distribution/OS set to Unspecified
- Milestone set to 0.84
- Severity set to Minor
Let's set this to block 0.84. If we don't pull in upstream code in time, we can just slip it to 0.86.
comment:5 Changed 15 years ago by erikos
- Bug Status changed from Unconfimed to Assigned
comment:6 Changed 15 years ago by tomeu
- Resolution set to fixed
- Status changed from assigned to closed
Ok, so the fix will appear in gtk+ 2.16 on which gnome 2.26 depends on.So we can close this because sugar 0.84 will depend on gnome 2.26.
comment:7 follow-up: ↓ 8 Changed 15 years ago by walter
- Resolution fixed deleted
- Status changed from closed to reopened
The bug persists on the latest Soas running on the XO hardware.
Soas-2009-03051021.iso
comment:8 in reply to: ↑ 7 Changed 15 years ago by tomeu
Replying to walter:
The bug persists on the latest Soas running on the XO hardware.
Soas-2009-03051021.iso
AFAIK, soas-1 has an older version of gtk2. We should test it on Soas-2.
comment:9 Changed 15 years ago by erikos
- Bug Status changed from Assigned to Resolved
- Resolution set to fixed
- Status changed from reopened to closed
Looks good in Soas-2 (containing gtk2 - 2.15) - I guess we can close it then. Soas-1 does have 2.14.x - did not make it into that i presume.
Benzea saw that it is because mozilla disabled gtk double buffering. This was due to how they used to draw the text caret several years ago but in the meantime they have rewritten it making that hack unnecessary.
Removing this call fixes the preview, though should be causing one unnecessary copy at every redraw:
http://mxr.mozilla.org/seamonkey/source/widget/src/gtk2/nsWindow.cpp#3265