#1439 closed enhancement (obsolete)
Report a problem control panel
| Reported by: | wadeb | Owned by: | wadeb |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | Sugar | Version: | Unspecified |
| Severity: | Unspecified | Keywords: | r! |
| Cc: | bernie | Distribution/OS: | Unspecified |
| Bug Status: | Unconfirmed |
Description
This ticket holds the patch files and server script for http://wiki.sugarlabs.org/go/Features/Problem_Reports.
Attachments (4)
Change History (13)
Changed 14 years ago by wadeb
comment:1 Changed 14 years ago by wadeb
- Owner changed from tomeu to wadeb
- Status changed from new to accepted
comment:2 Changed 14 years ago by wadeb
Server script updated to use PDO API which is installed on sunjammer.
comment:3 Changed 14 years ago by wadeb
- Keywords r? added
The patch has been updated:
The log server is now stored in Gconf; default is logcollect.sugarlabs.org.
If the upload fails, the log is copied to the journal.
Bug fixes and cleanups to log collecting.
New icon from Gary C. Martin.
Patch is now ready for feedback.
comment:4 Changed 13 years ago by erikos
The Feature discussion is here: http://lists.sugarlabs.org/archive/sugar-devel/2009-December/021386.html
comment:5 Changed 13 years ago by tomeu
- Keywords r! added; r? removed
logcollect.py uses a style different from the rest of Sugar, can you modify it according to http://wiki.sugarlabs.org/go/Development_Team/Code_guidelines ?
+def save_logs_to_journal(archive_name):
Should be private?
+ ds = datastore.create()
jobject is more common, grepping the sources helps to find consistent names
+ ds.metadata['title'] = archive_name + ds.metadata['mime_type'] = 'application/zip'
I'm a bit concerned about users not being able to relate these entries to bug reports. Can we have a more descriptive title? And maybe the insect icon?
+ del ds
Not needed.
+ _logger.debug('Saving %s to the journal.' % archive_name)
Better avoid using % in debug messages because of performance.
+ _logger.debug('Failed to collect logs:\n%s\n', e)
Better use _logger.exception so we don't lose information about the exception
+ if server[:7] != 'http://': + server = 'http://' + server + '/'
Won't be prepending http:// to an url that starts with https://?
+ # When the upload fails, fall back to saving the logs to the Journal.
Isn't this superfluous given the surrounding code?
+ _logger.debug('Failed to save logs to journal:\n%s\n', e)
Should be _logger.exception() instead?
+ description_label = gtk.Label(_('Please describe the problem you encountered.'))
Should this be about problems or could be more general?
comment:6 Changed 13 years ago by walter
- Milestone changed from 0.88 to 0.90
Seems to be some unanswered questions post review. Moving to 0.90
comment:7 Changed 13 years ago by bernie
- Cc bernie added
It would be great if we could have this feature. Is anyone pushing it?
comment:8 Changed 10 years ago by dnarvaez
- Resolution set to obsolete
- Status changed from accepted to closed
Sadly obsolete patches.
Option 1 for Log activity (doesn't work): Bring up control panel when the Upload logs button is clicked.