Opened 10 years ago

Closed 10 years ago

Last modified 6 years ago

#1435 closed defect (fixed)

Do no use random color if metadata color is not valid

Reported by: alsroot Owned by: alsroot
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Sugar Version: 0.85.x
Severity: Unspecified Keywords: r+
Cc: eben, garycmartin, hoboprimate Distribution/OS: Unspecified
Bug Status: Needinfo

Description

Using random color for entries that are not valid could be confusing:

  • random colors look like valid colors
  • random colors have been changed on every update(for the same Journal entry for example)

So, using grey colors can signalize that entry is not valid.

Attachments (2)

sugar-1435.patch (1.3 KB) - added by alsroot 10 years ago.
sugar-1435.2.patch (1.3 KB) - added by alsroot 10 years ago.

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by alsroot

comment:1 Changed 10 years ago by alsroot

Related to #1408

comment:2 Changed 10 years ago by alsroot

  • Bug Status changed from Unconfirmed to Needinfo
  • Cc eben garycmartin hoboprimate added

What designers say for using grey colors for broken icon-color?
we have grey colors already for disabled items

comment:3 follow-up: Changed 10 years ago by eben

What does it mean to have an "invalid" entry? I understand the need to have a sane fallback, of course, which merits a decision here, but shouldn't this be an edge case?

That said, we shouldn't be using gray for this purpose, in my mind, since that can potentially be confused with uninstantiated activities. We're talking about entries for ongoing activities here, and those need to be colored to signify that state. I think the only logical choice, when no other identity is known, is to use the identity of the current owner. That is, if it's in my Journal and my Journal isn't told its identity (its colors), then it should assume my colors instead.

This is likely to be the correct choice anyway in a number of cases, such as files copied to the Journal from non-Sugar sources, files downloaded by activities, etc. This application of identity should occur at the time an entry is added to the Journal, not at the time it is launched, so that all future actions (starting, sending, copying, etc.) retain that identity going forward.

comment:4 in reply to: ↑ 3 Changed 10 years ago by alsroot

Replying to eben:

What does it mean to have an "invalid" entry? I understand the need to have a sane fallback, of course, which merits a decision here, but shouldn't this be an edge case?

In most cases, I think, it could be remains after broken ds, but activity could create ds entries with missed icon-color property.

That said, we shouldn't be using gray for this purpose, in my mind, since that can potentially be confused with uninstantiated activities. We're talking about entries for ongoing activities here, and those need to be colored to signify that state. I think the only logical choice, when no other identity is known, is to use the identity of the current owner. That is, if it's in my Journal and my Journal isn't told its identity (its colors), then it should assume my colors instead.

This is likely to be the correct choice anyway in a number of cases, such as files copied to the Journal from non-Sugar sources, files downloaded by activities, etc. This application of identity should occur at the time an entry is added to the Journal, not at the time it is launched, so that all future actions (starting, sending, copying, etc.) retain that identity going forward.

Ok, I'll post new patch.

Changed 10 years ago by alsroot

comment:5 Changed 10 years ago by tomeu

  • Keywords r+ added; r? removed
  • Owner changed from erikos to alsroot
  • Status changed from new to assigned

comment:7 Changed 6 years ago by dnarvaez

  • Component changed from sugar-toolkit to Sugar
Note: See TracTickets for help on using tickets.