Opened 14 years ago

Closed 14 years ago

Last modified 10 years ago

#1361 closed defect (fixed)

Cancel updating process in Update control panel component

Reported by: alsroot Owned by: tomeu
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: 0.85.x
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description


Attachments (4)

sugar-1361.patch​ (11.0 KB) - added by alsroot 14 years ago.
sugar-1361.2.patch​ (9.3 KB) - added by alsroot 14 years ago.
sugar-1361.3.patch​ (15.7 KB) - added by alsroot 14 years ago.
0001-Implement-functionality-of-the-cancel-button-1361.patch​ (8.6 KB) - added by tomeu 14 years ago.

Download all attachments as: .zip

Change History (12)

Changed 14 years ago by alsroot

comment:1 follow-up: Changed 14 years ago by erikos

  • Keywords r! added; r? removed

The "# ASLO knows only about stable SP releases" code is not really part of adding a cancel option, right? Would be better to put in a separate patch.

Can you state the impact on why the cancel button is more of a bug fix than a feature? Maybe a test case would emphasize it.

comment:2 in reply to: ↑ 1 Changed 14 years ago by alsroot

Replying to erikos:

The "# ASLO knows only about stable SP releases" code is not really part of adding a cancel option, right? Would be better to put in a separate patch.

yup better to push it from different commit, #1369

Can you state the impact on why the cancel button is more of a bug fix than a feature? Maybe a test case would emphasize it.

Having 50 activities could be pretty painful to wait for fetching metadata and moreover for downloading upgrades for them.

Changed 14 years ago by alsroot

comment:3 Changed 14 years ago by alsroot

  • Keywords r? added; r! removed

comment:4 Changed 14 years ago by alsroot

  • Keywords r? removed

Changed 14 years ago by alsroot

comment:5 Changed 14 years ago by alsroot

  • Keywords r? added

Changed 14 years ago by tomeu

comment:6 Changed 14 years ago by tomeu

As discussed in #sugar, for 0.86 might be better to implement a more limited cancel functionality for stability reasons.

comment:7 Changed 14 years ago by tomeu

  • Keywords r+ added; r? removed
  • Resolution set to fixed
  • Status changed from new to closed

r+'ed by Aleksey on #sugar:

​http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/3546b5b1

comment:8 Changed 10 years ago by dnarvaez

  • Milestone 0.86 deleted

Milestone 0.86 deleted

Note: See TracTickets for help on using tickets.