Opened 10 years ago

Closed 8 years ago

Last modified 6 years ago

#1236 closed task (fixed)

PEP8 fixes for sugar

Reported by: sascha_silbe Owned by: sascha_silbe
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Minor Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

pep8.py has lots of complaints for sugar. We didn't manage to get fixes for them checked in in time for 0.86, so need to do that for 0.88.

Change History (6)

comment:1 Changed 10 years ago by sascha_silbe

  • Owner changed from tomeu to sascha_silbe
  • Status changed from new to accepted

comment:2 follow-up: Changed 9 years ago by sascha_silbe

Can we (i.e. I) have a go at this now that 0.86 has been branched off? Do you want to review my changes or should I commit them (one commit per type of change, i.e. number of empty lines between blocks, overlong lines, ...) directly?

comment:3 in reply to: ↑ 2 Changed 9 years ago by tomeu

Replying to sascha_silbe:

Can we (i.e. I) have a go at this now that 0.86 has been branched off? Do you want to review my changes or should I commit them (one commit per type of change, i.e. number of empty lines between blocks, overlong lines, ...) directly?

Do you see any advantage on doing several commits instead of only one?

I think we should go through the review queue now, then do this cleanup and push it once for all.

comment:4 Changed 9 years ago by tomeu

  • Milestone changed from 0.88 to 0.90

comment:5 Changed 8 years ago by sascha_silbe

  • Resolution set to fixed
  • Status changed from accepted to closed

Landed as 69dbe0f to 3947e49.

comment:6 Changed 6 years ago by dnarvaez

  • Milestone 0.90 deleted

Milestone 0.90 deleted

Note: See TracTickets for help on using tickets.