#1235 closed defect (fixed)
Journal list view: jumping back to first page when popping up a palette
| Reported by: | sascha_silbe | Owned by: | alsroot |
|---|---|---|---|
| Priority: | Immediate | Milestone: | |
| Component: | Sugar | Version: | Git as of bugdate |
| Severity: | Major | Keywords: | r+ |
| Cc: | erikos, garycmartin | Distribution/OS: | Unspecified |
| Bug Status: | New |
Description
The Journal list view jumps back to the first page when opening a palette, making it impossible to resume old entries.
The attached patch fixes that by refreshing the list only on change from fully-obscured to visible, not on every minor visibility change.
Attachments (5)
Change History (26)
Changed 14 years ago by sascha_silbe
comment:1 Changed 14 years ago by tomeu
- Keywords r+ added; r? removed
- Owner changed from tomeu to sascha_silbe
- Status changed from new to assigned
Thanks, please push.
comment:2 Changed 14 years ago by alsroot
http://git.sugarlabs.org/projects/sugar/repos/thumbs-non-ds/commits/3bc29a944da05b87718ceda188ebd2f779c103b0
could be more relyable, since we have model all time uptodate
comment:3 Changed 14 years ago by alsroot
e.g. in case of changing entries w/o opening details view
comment:4 Changed 14 years ago by alsroot
related fix
http://git.sugarlabs.org/projects/sugar/repos/thumbs-non-ds/commits/05f9ed60c895b8adaac8ee419ff624e576c68674
Discrad cache while changing resultset #1235
comment:5 Changed 14 years ago by alsroot
last three comments are obsoleted
comment:6 Changed 14 years ago by alsroot
last patch is adapted version of previous two commit links
Changed 14 years ago by alsroot
comment:7 Changed 14 years ago by alsroot
last patch was rewrote according to irc discussion
Changed 14 years ago by alsroot
comment:8 Changed 14 years ago by alsroot
- Cc erikos garycmartin added
- Resolution set to fixed
- Status changed from assigned to closed
at the end another approach was chosen - just change vadjustment value
http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/18b089a07f68aa669d49ebdac726e5d71ab9985c
the bad thing with this way is after requery list view loses focus highliting(e.g. select row, after clicking on Favorite icon for this row it losses focus). One of possible decision is change focus color(for shell process not in gtkrc)
so, if its not ok with losing focus, please reopen ticket
comment:9 Changed 14 years ago by alsroot
- Keywords r? added; r+ removed
- Resolution fixed deleted
- Status changed from closed to reopened
Changed 14 years ago by alsroot
comment:10 Changed 14 years ago by tomeu
- Keywords r+ added; r? removed
- Owner changed from sascha_silbe to alsroot
- Status changed from reopened to assigned
Sounds good, thanks.
comment:11 follow-up: ↓ 14 Changed 14 years ago by alsroot
- Resolution set to fixed
- Status changed from assigned to closed
comment:12 Changed 14 years ago by erikos
Do the same for the activities list: http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/975a3bdbcc0f8e4e8efc41357109e6c8cf6173d0
comment:13 Changed 14 years ago by alsroot
- Resolution fixed deleted
- Status changed from closed to reopened
comment:14 in reply to: ↑ 11 ; follow-up: ↓ 15 Changed 14 years ago by alsroot
Replying to alsroot:
This commit leads to flickering while hide/show invoking in development ubuntu and mandriva repos, w/o this commit Journal doesn't flickering like in gentoo(just scrollbars movements).
So, in my mind we have odd consequences of tying to particular gtk version behaviour.
comment:15 in reply to: ↑ 14 Changed 14 years ago by alsroot
Replying to alsroot:
Replying to alsroot:
This commit leads to flickering while hide/show invoking in development ubuntu and mandriva repos, w/o this commit Journal doesn't flickering like in gentoo(just scrollbars movements).
So, in my mind we have odd consequences of tying to particular gtk version behaviour.
|TestCase|
- have move then one page of entries in Jorunal
- scroll to top
- scroll to one row down
- chage Favorite icon
- in last ubuntu/mandriva its flickering
comment:16 Changed 14 years ago by erikos
- Priority changed from Unspecified by Maintainer to Immediate
Changed 14 years ago by alsroot
comment:17 follow-up: ↓ 19 Changed 14 years ago by alsroot
- Keywords r? added; r+ removed
Its still not ideal, but it works w/o glitches in all of my environments.
And I guess we need to rewrite listview code in 0.88.
comment:18 Changed 14 years ago by alsroot
- Owner changed from alsroot to tomeu
- Status changed from reopened to assigned
comment:19 in reply to: ↑ 17 Changed 14 years ago by tomeu
- Keywords r+ added; r? removed
- Owner changed from tomeu to alsroot
Replying to alsroot:
And I guess we need to rewrite listview code in 0.88.
Well, mostly the model I guess, so we don't reset it. It may help if the journal accesses directly the xapian index, instead of going through the DS.
comment:20 Changed 14 years ago by alsroot
- Resolution set to fixed
- Status changed from assigned to closed
fix Journal list view jumping back to first page on showing a Palette