Opened 11 years ago

Closed 11 years ago

Last modified 7 years ago

#1046 closed defect (wontfix)

Traceback while trying to delete no-data .xo Journal entry

Reported by: sascha_silbe Owned by: tomeu
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Major Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

While trying do delete a Journal entry that has no data associated with it ("data" does not exist) and "should" contain a .xo, I get the following traceback:

1247503556.186785 DEBUG root: get_file asked for entry with id dbus.ByteArray('7c20578d-9be7-4a05-af83-0dbe7f172518', variant_level=1)
1247503556.195226 DEBUG root: TempFilePath created '/tmp/tmpFoumNG'
Traceback (most recent call last):
  File "/home/sugar/sugar-jhbuild/install/lib/python2.5/site-packages/jarabe/journal/palettes.py", line 139, in __erase_activate_cb
    bundle = misc.get_bundle(self._metadata)
  File "/home/sugar/sugar-jhbuild/install/lib/python2.5/site-packages/jarabe/journal/misc.py", line 102, in get_bundle
    return ActivityBundle(file_path)
  File "/home/sugar/sugar-jhbuild/install/lib/python2.5/site-packages/sugar/bundle/activitybundle.py", line 48, in __init__
    Bundle.__init__(self, path)
  File "/home/sugar/sugar-jhbuild/install/lib/python2.5/site-packages/sugar/bundle/bundle.py", line 68, in __init__
    self._zip_file = zipfile.ZipFile(self._path)
  File "/usr/lib/python2.5/zipfile.py", line 346, in __init__
    self._GetContents()
  File "/usr/lib/python2.5/zipfile.py", line 366, in _GetContents
    self._RealGetContents()
  File "/usr/lib/python2.5/zipfile.py", line 376, in _RealGetContents
    endrec = _EndRecData(fp)
  File "/usr/lib/python2.5/zipfile.py", line 133, in _EndRecData
    fpin.seek(-22, 2)               # Assume no archive comment.
IOError: [Errno 22] Invalid argument

I've not been able to reproduce the bug that produced this entry, but Journal shouldn't crash on it anyway (there's no reason for datastore to consider the entry invalid, so any activity is free to produce something like this).

Change History (2)

comment:1 Changed 11 years ago by sascha_silbe

  • Resolution set to wontfix
  • Status changed from new to closed

I can still trigger the traceback, but it doesn't seem to cause any problem (anymore?). While we could print an explicit error instead of a traceback (it's hard to tell from the traceback that the file simply doesn't exist), it shouldn't be a problem during regular operation. Closing for now, feel free to reopen.

comment:2 Changed 7 years ago by dnarvaez

  • Milestone 0.86 deleted

Milestone 0.86 deleted

Note: See TracTickets for help on using tickets.