From 2d2b07e0db0da481bf8e48c285903837a3f968ff Mon Sep 17 00:00:00 2001 From: anubhav Date: Sat, 2 Oct 2010 21:31:28 +0530 Subject: [PATCH] Mirror arrow icons when running in RTL mode(SL#306) This patch inserts a if condition in the intiallization of the the class of the toolbar.Which check for the direction of the language is right to left or left to right thus reverting the buttons of toolbar (in the case of rtl ) This patch handles the problem with edit toolbar and web toolbar in browse activity --- source/browse/edittoolbar.py | 15 +++++++++++---- webtoolbar.py | 13 ++++++++++--- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/source/browse/edittoolbar.py b/source/browse/edittoolbar.py index 4658683..122475b 100644 --- a/source/browse/edittoolbar.py +++ b/source/browse/edittoolbar.py @@ -33,9 +33,16 @@ class EditToolbar(activity.EditToolbar): def __init__(self, act): activity.EditToolbar.__init__(self) - + + if gtk.widget_get_default_direction() == gtk.TEXT_DIR_RTL: + self.nextbutton = 'go-previous-paired' + self.previousbutton = 'go-next-paired' + + else : + self.nextbutton = 'go-previous-paired' + self.previousbutton = 'go-next-paired' self._activity = act - + self.undo.connect('clicked', self.__undo_cb) self.redo.connect('clicked', self.__redo_cb) self.copy.connect('clicked', self.__copy_cb) @@ -88,14 +95,14 @@ class EditToolbar(activity.EditToolbar): self.insert(search_item, -1) search_item.show() - self._prev = ToolButton('go-previous-paired') + self._prev = ToolButton(self.previousbutton) self._prev.set_tooltip(_('Previous')) self._prev.props.sensitive = False self._prev.connect('clicked', self.__find_previous_cb) self.insert(self._prev, -1) self._prev.show() - self._next = ToolButton('go-next-paired') + self._next = ToolButton(self.nextbutton) self._next.set_tooltip(_('Next')) self._next.props.sensitive = False self._next.connect('clicked', self.__find_next_cb) diff --git a/source/browse/webtoolbar.py b/source/browse/webtoolbar.py index 69a3c8e..7263eb9 100644 --- a/source/browse/webtoolbar.py +++ b/source/browse/webtoolbar.py @@ -234,7 +234,14 @@ class PrimaryToolbar(ToolbarBox): self._activity = act self._tabbed_view = tabbed_view - + if gtk.widget_get_default_direction() == gtk.TEXT_DIR_RTL: + self.nextbutton = 'go-previous-paired' + self.previousbutton = 'go-next-paired' + + else : + self.nextbutton = 'go-next-paired' + self.previousbutton = 'go-previous-paired' + self._loading = False activity_button = ActivityToolbarButton(self._activity) @@ -256,14 +263,14 @@ class PrimaryToolbar(ToolbarBox): self.toolbar.insert(entry_item, -1) entry_item.show() - self._back = ToolButton('go-previous-paired') + self._back = ToolButton(self.previousbutton) self._back.set_tooltip(_('Back')) self._back.props.sensitive = False self._back.connect('clicked', self._go_back_cb) self.toolbar.insert(self._back, -1) self._back.show() - self._forward = ToolButton('go-next-paired') + self._forward = ToolButton(self.nextbutton) self._forward.set_tooltip(_('Forward')) self._forward.props.sensitive = False self._forward.connect('clicked', self._go_forward_cb) -- 1.7.0.4