Ticket #4307: 0001-Clipboard-Menu-remove-progress-bar-part-of-4307.patch

File 0001-Clipboard-Menu-remove-progress-bar-part-of-4307.patch, 2.5 KB (added by erikos, 11 years ago)

Clipboard-Menu-remove-progress-bar

  • src/jarabe/frame/clipboardmenu.py 

    From 8c48641642080d72acb2c95ef6624d27d2f31724 Mon Sep 17 00:00:00 2001
From: Simon Schampijer <simon@laptop.org>
Date: Fri, 21 Dec 2012 11:15:15 +0100
Subject: [PATCH shell] Clipboard Menu: remove progress bar, part of #4307

Our GTKMenu based Palette does only support
GtkMenuItems as entries. We ca nnot switch to our
custom Palettes as those do not support sub menus.

As the progress bar is rarely used we decided to
remove it.

Signed-off-by: Simon Schampijer <simon@laptop.org>
---
 src/jarabe/frame/clipboardmenu.py | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/src/jarabe/frame/clipboardmenu.py b/src/jarabe/frame/clipboardmenu.py
index bef007b..e6766fb 100644
    a b class ClipboardMenu(Palette): 
    5151        cb_service.connect('object-state-changed',
    5252                           self._object_state_changed_cb)
    5353
    54         self._progress_bar = None
    55 
    5654        self._remove_item = MenuItem(pgettext('Clipboard', 'Remove'),
    5755                                     'list-remove')
    5856        self._remove_item.connect('activate', self._remove_item_activate_cb)
    … … class ClipboardMenu(Palette): 
    128126            self._open_item.props.sensitive = False
    129127            self._journal_item.props.sensitive = False
    130128
    131         self._update_progress_bar()
    132 
    133129    def _get_activities(self):
    134130        mime_type = self._cb_object.get_mime_type()
    135131        if not mime_type:
    … … class ClipboardMenu(Palette): 
    142138        else:
    143139            return ''
    144140
    145     def _update_progress_bar(self):
    146         percent = self._cb_object.get_percent()
    147         if percent == 100.0:
    148             if self._progress_bar:
    149                 self._progress_bar = None
    150                 self.set_content(None)
    151         else:
    152             if self._progress_bar is None:
    153                 self._progress_bar = Gtk.ProgressBar()
    154                 self._progress_bar.show()
    155                 self.set_content(self._progress_bar)
    156 
    157             self._progress_bar.props.fraction = percent / 100.0
    158             self._progress_bar.props.text = '%.2f %%' % percent
    159 
    160141    def _object_state_changed_cb(self, cb_service, cb_object):
    161142        if cb_object != self._cb_object:
    162143            return
    … … class ClipboardMenu(Palette): 
    168149        preview = self._cb_object.get_preview()
    169150        if preview:
    170151            self.props.secondary_text = GLib.markup_escape_text(preview)
    171         self._update_progress_bar()
    172152        self._update_items_visibility()
    173153        self._update_open_submenu()
    174154