0001-Revert-Move-to-cjson-and-drop-pyjson-and-simplejson.patch on Ticket #1553 – Attachment – Sugar Labs

src/jarabe/journal/expandedentry.py

From 97c978092da7f66db0f6f58782a7bee801fde5ac Mon Sep 17 00:00:00 2001
From: Daniel Drake <dsd@laptop.org>
Date: Wed, 18 Nov 2009 12:17:47 +0000
Subject: [PATCH] Revert "Move to cjson and drop pyjson and simplejson"

This reverts commit ee4535c98ae74347e7072909d49dcf8a5e16ca7b.

cjson has a big bug dealing with slashes, this is a significant
long-term bug and upstream has not been responsive other than
acknowledging it. This bug breaks journal entry bundles.
http://dev.sugarlabs.org/ticket/1553

Thanks to Martin Langhoff for identifying and researching this issue
---
 src/jarabe/journal/expandedentry.py      |    6 ++++--
 src/jarabe/journal/journalentrybundle.py |    9 +++++++--
 src/jarabe/journal/listmodel.py          |    6 ++++--
 src/jarabe/model/bundleregistry.py       |    6 +++---
 src/jarabe/model/owner.py                |    4 ++--
 5 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/src/jarabe/journal/expandedentry.py b/src/jarabe/journal/expandedentry.py
index 94d90ed..4463cac 100644

  import hippo
 import cairo
 import gobject
 import gtk
 import cjson
+import json
 from sugar.graphics import style
 from sugar.graphics.icon import CanvasIcon
-…
+ class ExpandedEntry(hippo.CanvasBox):
         if self._metadata.has_key('buddies') and \
                 self._metadata['buddies']:
+            buddies = cjson.decode(self._metadata['buddies']).values()
+            # json cannot read unicode strings
+            buddies_str = self._metadata['buddies'].encode('utf8')
+            buddies = json.read(buddies_str).values()
             vbox.append(BuddyList(buddies))
             return vbox
         else:

src/jarabe/journal/journalentrybundle.py

diff --git a/src/jarabe/journal/journalentrybundle.py b/src/jarabe/journal/journalentrybundle.py
index ebe7ec3..a0bc935 100644

  import os
 import tempfile
 import shutil
 import cjson
+import json
 import dbus
 from sugar.bundle.bundle import Bundle, MalformedBundleException
-…
+ class JournalEntryBundle(Bundle):
         if not os.path.exists(metadata_path):
             raise MalformedBundleException(
                     'Bundle must contain the file "_metadata.json"')
+        return cjson.decode(open(metadata_path, 'r').read())
+        f = open(metadata_path, 'r')
+        try:
+            json_data = f.read()
+        finally:
+            f.close()
+        return json.read(json_data)
     def _read_preview(self, uid, bundle_dir):
         preview_path = os.path.join(bundle_dir, 'preview', uid)

src/jarabe/journal/listmodel.py

diff --git a/src/jarabe/journal/listmodel.py b/src/jarabe/journal/listmodel.py
index 32df853..bc53a9c 100644

-                      a
 import logging
 import cjson
+import json
 import gobject
 import gtk
-…
+ class ListModel(gtk.GenericTreeModel, gtk.TreeDragSource):
         self._cached_row.append(int(metadata.get('progress', 100)))
         if metadata.get('buddies', ''):
+            buddies = cjson.decode(metadata['buddies']).values()
+            # json cannot read unicode strings
+            buddies_str = metadata['buddies'].encode('utf8')
+            buddies = json.read(buddies_str).values()
         else:
             buddies = []

src/jarabe/model/bundleregistry.py

diff --git a/src/jarabe/model/bundleregistry.py b/src/jarabe/model/bundleregistry.py
index b754952..aa49c72 100644

  import traceback
 import gobject
 import gio
 import cjson
+import simplejson
 from sugar.bundle.activitybundle import ActivityBundle
 from sugar.bundle.contentbundle import ContentBundle
-…
+ class BundleRegistry(gobject.GObject):
     def _load_favorites(self):
         favorites_path = env.get_profile_path('favorite_activities')
         if os.path.exists(favorites_path):
             favorites_data = cjson.decode(open(favorites_path).read())
+            favorites_data = simplejson.load(open(favorites_path))
             favorite_bundles = favorites_data['favorites']
             if not isinstance(favorite_bundles, dict):
-…
+ class BundleRegistry(gobject.GObject):
         path = env.get_profile_path('favorite_activities')
         favorites_data = {'defaults-mtime': self._last_defaults_mtime,
                           'favorites': self._favorite_bundles}
         open(path, 'w').write(cjson.encode(favorites_data))
+        simplejson.dump(favorites_data, open(path, 'w'), indent=1)
     def is_installed(self, bundle):
         # TODO treat ContentBundle in special way

src/jarabe/model/owner.py

diff --git a/src/jarabe/model/owner.py b/src/jarabe/model/owner.py
index 2075f08..17996e6 100644

-                      a
 import gobject
 import os
-import cjson
 import gconf
+import simplejson
 from telepathy.interfaces import CHANNEL_TYPE_TEXT
-…
+ class Owner(gobject.GObject):
             bundle_id = 'org.laptop.Chat'
         else:
             bundle_id = 'org.laptop.VideoChat'
         tp_channel = cjson.encode([bus_name, connection, channel])
+        tp_channel = simplejson.dumps([bus_name, connection, channel])
         self._invites.add_private_invite(tp_channel, bundle_id)
     def _activity_disappeared_cb(self, pservice, activity):

Context Navigation

Ticket #1553: 0001-Revert-Move-to-cjson-and-drop-pyjson-and-simplejson.patch

src/jarabe/journal/expandedentry.py

src/jarabe/journal/journalentrybundle.py

src/jarabe/journal/listmodel.py

src/jarabe/model/bundleregistry.py

src/jarabe/model/owner.py

Download in other formats: