Ticket #1442: 0001-Reject-activity-bundles-which-require-a-newer-versio.patch

src/jarabe/model/bundleregistry.py

@@ -209 +209 @@
         else:
             return False
 
+    def _compare_versions(self, a, b):
+        """Return True if version a is newer than version b
+        
+        Both a and b must be in the form x.y.z"""
+        
+        a_list = a.split('.')
+        b_list = b.split('.')
+
+        for i in range(len(a_list)):
+            if int(a_list[i]) > int(b_list[i]):
+                return True
+            elif int(a_list[i]) < int(b_list[i]):
+                return False
+        return False
+
     def _add_bundle(self, bundle_path, install_mime_type=False):
         logging.debug('STARTUP: Adding bundle %r', bundle_path)
         try:
@@ -219 +234 @@
             logging.exception('Error loading bundle %r', bundle_path)
             return None
 
+        # Compare version strings.
+        if self._compare_versions(bundle.get_sugar_version(), config.version):
+            logging.exception('Bundle %r requires Sugar version %s or newer' %
+                              (bundle_path, bundle.get_sugar_version()))
+            return None
+
         bundle_id = bundle.get_bundle_id()
         installed = self.get_bundle(bundle_id)