wrong path for wpa_passphrase on Debian

[sascha_silbe]

On Debian (derivates), wpa_passphrase is in /usr/bin, not /usr/sbin. As the path is currently hardcoded WPA support breaks on those distros.

[sascha_silbe]

Another way to solve this would be to remove the hardcoded path on the wpa_passphrase call and add /usr/sbin to PATH during startup of Sugar.
Personally I'd prefer that solution since having /usr/sbin in PATH is useful on it's own anyway.

[tomeu]

Replying to sascha_silbe:

Another way to solve this would be to remove the hardcoded path on the wpa_passphrase call and add /usr/sbin to PATH during startup of Sugar.
Personally I'd prefer that solution since having /usr/sbin in PATH is useful on it's own anyway.

Yeah, I would prefer if we used python's implementation for finding a binary to execute rather than cooking our own. Though I'm unsure about setting the PATH env var before starting Sugar, as this is something that distro people will mess with and may be better to avoid increasing the number of things that may go wrong. Perhaps the python lib has a facility to specify a custom set of dir paths?

[sascha_silbe]

Yeah, I would prefer if we used python's implementation for finding a binary to execute rather than cooking our own. Though I'm unsure about setting the PATH env var before starting Sugar, as this is something that distro people will mess with and may be better to avoid increasing the number of things that may go wrong.

How about setting it in the "sugar" script?

Perhaps the python lib has a facility to specify a custom set of dir paths?

Unfortunately not, that's why my patch is so convoluted.

[tomeu]

Replying to sascha_silbe:

Yeah, I would prefer if we used python's implementation for finding a binary to execute rather than cooking our own. Though I'm unsure about setting the PATH env var before starting Sugar, as this is something that distro people will mess with and may be better to avoid increasing the number of things that may go wrong.

How about setting it in the "sugar" script?

Yeah, I think that's fine. This may help as well with instructions for the command line, as all distros where Sugar runs will have /usr/sbin in PATH.

[tomeu]

Replying to tomeu:

Replying to sascha_silbe:

Yeah, I would prefer if we used python's implementation for finding a binary to execute rather than cooking our own. Though I'm unsure about setting the PATH env var before starting Sugar, as this is something that distro people will mess with and may be better to avoid increasing the number of things that may go wrong.

How about setting it in the "sugar" script?

Yeah, I think that's fine. This may help as well with instructions for the command line, as all distros where Sugar runs will have /usr/sbin in PATH.

Bad chose of words. What I wanted to say is by setting the PATH env var in the sugar script, the effective PATH in the terminal activity will include /usr/sbin on all distros, so the same examples will work.

[sascha_silbe]

locate wpa_passphrase using PATH; append /sbin and /usr/sbin to PATH in "sugar"

[tomeu]

Pushed, thanks!