favoritesview.py: icon-color KeyError

[sascha_silbe]

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.5/dbus/connection.py", line 578, in msg_reply_handler
    reply_handler(*message.get_args_list(**get_args_opts))
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-packages/jarabe/desktop/favoritesview.py", line 383, in <lambda>
    entries, total_count, callback_cb)
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-packages/jarabe/desktop/favoritesview.py", line 394, in __reply_handler_cb
    callback_cb(entries)
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-packages/jarabe/desktop/favoritesview.py", line 458, in __get_last_activity_async_cb
    self._update()
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-packages/jarabe/desktop/favoritesview.py", line 467, in _update
    self.props.xo_color = XoColor(first_entry['icon-color'])
KeyError: 'icon-color'

This probably was the cause for
a) this system disappearing from the neighborhood/group view of another system and
b) the (own) buddy icon on neighborhood view (but not group view) not reacting to right click anymore.

[sascha_silbe]

complete shell.log including this and other errors

[sascha_silbe]

This probably happens on an entry imported with copy-to-journal. I might also have manually created some metadata (but not icon-color) for the entry to be recognized by Turtle Art.
Nevertheless the shell shouldn't traceback on a missing color attribute (default probably should be the owners colors).

[tomeu]

Replying to sascha_silbe:

This probably happens on an entry imported with copy-to-journal. I might also have manually created some metadata (but not icon-color) for the entry to be recognized by Turtle Art.
Nevertheless the shell shouldn't traceback on a missing color attribute (default probably should be the owners colors).

Agreed, maybe Gary and/or Eben want to comment about what colors to use when the metadata property is missing?

[eben]

Yes, using the owner's colors seems to be the only logical choice we have.

[alsroot]

Attached patch tries to use 'icon-color' metadata property and uses owners colors otherwise(except colors for bundles).

[erikos]

The patch looks good to me. Sasche can you add an executable test case and verify Aleksey's patch.

Thanks

[tomeu]

r+ but gettext is a module part of the python std lib so goes in the first group of imports.

[alsroot]

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/c3619ae5a1fb0950edd2876700cee93f6d702f1f